Skip to content

Commit 5947d20

Browse files
authored
Merge pull request #357 from deivid-rodriguez/simplify_rake_test_loader
Simplify default rake test loader
2 parents 7fc761c + 063950d commit 5947d20

File tree

2 files changed

+2
-37
lines changed

2 files changed

+2
-37
lines changed

lib/rake/testtask.rb

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -181,44 +181,9 @@ def run_code # :nodoc:
181181
when :testrb
182182
"-S testrb"
183183
when :rake
184-
"#{rake_include_arg} \"#{rake_loader}\""
184+
"-r#{__dir__}/rake_test_loader"
185185
end
186186
end
187187

188-
def rake_loader # :nodoc:
189-
find_file("rake/rake_test_loader") or
190-
fail "unable to find rake test loader"
191-
end
192-
193-
def find_file(fn) # :nodoc:
194-
$LOAD_PATH.each do |path|
195-
file_path = File.join(path, "#{fn}.rb")
196-
return file_path if File.exist? file_path
197-
end
198-
nil
199-
end
200-
201-
def rake_include_arg # :nodoc:
202-
spec = Gem.loaded_specs["rake"]
203-
if spec.respond_to?(:default_gem?) && spec.default_gem?
204-
""
205-
else
206-
"-I\"#{rake_lib_dir}\""
207-
end
208-
end
209-
210-
def rake_lib_dir # :nodoc:
211-
find_dir("rake") or
212-
fail "unable to find rake lib"
213-
end
214-
215-
def find_dir(fn) # :nodoc:
216-
$LOAD_PATH.each do |path|
217-
file_path = File.join(path, "#{fn}.rb")
218-
return path if File.exist? file_path
219-
end
220-
nil
221-
end
222-
223188
end
224189
end

test/test_rake_test_task.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def test_run_code_rake
128128
t.loader = :rake
129129
end
130130

131-
assert_match(/\A-I".*?" ".*?"\Z/, test_task.run_code)
131+
assert_match(/\A-r.*?\Z/, test_task.run_code)
132132
ensure
133133
Gem.loaded_specs["rake"] = rake
134134
end

0 commit comments

Comments
 (0)