Avoid raising debuggee not finished error if assertions failed

When assertions failed, we should let the AssertionFailedError surface
and not calling flunk so we can get correct failure messages.

Author: st0012

test/support/protocol_test_case.rb

@@ -334,9 +334,12 @@ def execute_dap_scenario scenario
 
       attach_to_dap_server
       scenario.call
+    rescue Test::Unit::AssertionFailedError => e
+      is_assertion_failure = true
+      raise e
     ensure
       kill_remote_debuggee test_info
-      if test_info.failed_process
+      if test_info.failed_process && !is_assertion_failure
         flunk create_protocol_message "Expected the debuggee program to finish"
       end
       # Because the debuggee may be terminated by executing the following operations, we need to run them after `kill_remote_debuggee` method.
@@ -365,9 +368,12 @@ def execute_cdp_scenario_ scenario
       res = find_response :method, 'Debugger.paused', 'C<D'
       @crt_frames = res.dig(:params, :callFrames)
       scenario.call
+    rescue Test::Unit::AssertionFailedError => e
+      is_assertion_failure = true
+      raise e
     ensure
       kill_remote_debuggee test_info
-      if test_info.failed_process
+      if test_info.failed_process && !is_assertion_failure
         flunk create_protocol_message "Expected the debuggee program to finish"
       end
       # Because the debuggee may be terminated by executing the following operations, we need to run them after `kill_remote_debuggee` method.

test/support/protocol_test_case_test.rb

@@ -3,14 +3,29 @@
 require_relative 'protocol_test_case'
 
 module DEBUGGER__
-  class TestFrameworkTestHOge < ProtocolTestCase
-    PROGRAM = <<~RUBY
-      1| a=1
-    RUBY
-
+  class TestProtocolTestCase < ProtocolTestCase
     def test_the_test_fails_when_debuggee_doesnt_exit
+      program = <<~RUBY
+        1| a=1
+      RUBY
+
       assert_fail_assertion do
-        run_protocol_scenario PROGRAM do
+        run_protocol_scenario program do
+        end
+      end
+    end
+
+    def test_the_assertion_failure_takes_presedence_over_debuggee_not_exiting
+      program = <<~RUBY
+        1| a = 2
+        2| b = 3
+      RUBY
+
+      assert_raise_message(/<\"100\"> expected but was/) do
+        run_protocol_scenario program do
+          req_add_breakpoint 2
+          req_continue
+          assert_repl_result({value: '100', type: 'Integer'}, 'a')
         end
       end
     end