Skip to content

Missing case for Rails/EnvLocal #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bquorning opened this issue May 7, 2025 · 1 comment
Open

Missing case for Rails/EnvLocal #1478

bquorning opened this issue May 7, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@bquorning
Copy link
Contributor

The Rails/EnvLocal cop will detect cases like

Rails.env.development? || Rails.env.test?

and

Rails.env.development? || Rails.env.test? || foo?

but it will currently not detect this case:

foo? || Rails.env.development? || Rails.env.test?

Would it be possible to change the cop to catch such a case?
@koic
Copy link
Member

koic commented May 7, 2025

Yeah, this looks like a false negative.

@koic koic added the enhancement New feature or request label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koic @bquorning