Skip to content

Commit 9d4c303

Browse files
author
Michele Nasti
committed
Signal AD_RENDER_FAILED / AD_RENDER_SUCCEEDED events to Prebid (prebid#152)
1 parent 0c0e46f commit 9d4c303

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/renderingManager.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ export function renderCrossDomain(win, adId, pubAdServerDomain = '', pubUrl) {
110110
}
111111
}
112112

113-
114113
function requestAdFromPrebid() {
115114
let message = {
116115
message: 'Prebid Request',

test/spec/renderingManager_spec.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,8 @@ describe('renderingManager', function() {
7676
let iframeStub;
7777
let triggerPixelSpy;
7878
let mockWin;
79-
let env;
80-
let renderObject;
8179
let ucTagData;
8280
let mockIframe;
83-
let eventSource;
8481

8582
beforeEach(function(){
8683
mockIframe = createMockIframe();
@@ -147,13 +144,13 @@ describe('renderingManager', function() {
147144
info: {
148145
reason: 'preventWritingOnMainDocument'
149146
}
150-
})
147+
});
151148
});
152149

153150
it('on ads that have no markup or adUrl', () => {
154151
mockPrebidResponse({
155152
adId: '123',
156-
})
153+
});
157154
expectEventMessage({
158155
adId: '123',
159156
event: RENDER_FAILED,
@@ -165,7 +162,7 @@ describe('renderingManager', function() {
165162

166163
it('on exceptions', () => {
167164
iframeStub.callsFake(() => {
168-
throw new Error()
165+
throw new Error();
169166
});
170167
mockPrebidResponse({
171168
adId: '123',
@@ -179,7 +176,7 @@ describe('renderingManager', function() {
179176
reason: 'exception'
180177
}
181178
});
182-
})
179+
});
183180
});
184181
describe('should post AD_RENDER_SUCCEEDED', () => {
185182
it('on ad with markup', () => {

0 commit comments

Comments
 (0)