Signal AD_RENDER_FAILED / AD_RENDER_SUCCEEDED events to Prebid (prebid#152)

Author: Michele Nasti

src/renderingManager.js

@@ -55,44 +55,47 @@ export function renderCrossDomain(win, adId, pubAdServerDomain = '', pubUrl) {
     }
 
     if (adObject.message && adObject.message === 'Prebid Response' &&
-      adObject.adId === adId &&
-      (adObject.ad || adObject.adUrl)) {
-      let body = win.document.body;
-      let ad = adObject.ad;
-      let url = adObject.adUrl;
-      let width = adObject.width;
-      let height = adObject.height;
+      adObject.adId === adId) {
+      try {
+        let body = win.document.body;
+        let ad = adObject.ad;
+        let url = adObject.adUrl;
+        let width = adObject.width;
+        let height = adObject.height;
 
-      if (adObject.mediaType === 'video') {
-        signalRenderResult(false, {
-          reason: 'preventWritingOnMainDocument',
-          message: `Cannot render video ad ${adId}`
-        });
-        console.log('Error trying to write ad.');
-      } else if (ad) {
-        const iframe = getEmptyIframe(adObject.height, adObject.width);
-        body.appendChild(iframe);
-        iframe.contentDocument.open();
-        iframe.contentDocument.write(ad);
-        iframe.contentDocument.close();
-        signalRenderResult(true);
-      } else if (url) {
-        const iframe = getEmptyIframe(height, width);
-        iframe.style.display = 'inline';
-        iframe.style.overflow = 'hidden';
-        iframe.src = url;
+        if (adObject.mediaType === 'video') {
+          signalRenderResult(false, {
+            reason: 'preventWritingOnMainDocument',
+            message: `Cannot render video ad ${adId}`
+          });
+          console.log('Error trying to write ad.');
+        } else if (ad) {
+          const iframe = getEmptyIframe(adObject.height, adObject.width);
+          body.appendChild(iframe);
+          iframe.contentDocument.open();
+          iframe.contentDocument.write(ad);
+          iframe.contentDocument.close();
+          signalRenderResult(true);
+        } else if (url) {
+          const iframe = getEmptyIframe(height, width);
+          iframe.style.display = 'inline';
+          iframe.style.overflow = 'hidden';
+          iframe.src = url;
 
-        insertElement(iframe, document, 'body');
-        signalRenderResult(true);
-      } else {
-        signalRenderResult(false, {
-          reason: 'noAd',
-          message: `No ad for ${adId}`
-        });
-        console.log(`Error trying to write ad. No ad for bid response id: ${id}`);
+          insertElement(iframe, document, 'body');
+          signalRenderResult(true);
+        } else {
+          signalRenderResult(false, {
+            reason: 'noAd',
+            message: `No ad for ${adId}`
+          });
+          console.log(`Error trying to write ad. No ad markup or adUrl for ${adId}`);
+        }
+      } catch (e) {
+        signalRenderResult(false, { reason: "exception", message: e.message });
+        console.log(`Error in rendering ad`, e);
       }
     }
-  }
 
   function signalRenderResult(success, { reason, message } = {}) {
     const payload = {

test/spec/renderingManager_spec.js

@@ -89,19 +89,19 @@ describe('renderingManager', function() {
         protocol: 'http',
         host: 'example.com'
       });
-      iframeStub.returns(mockIframe);
-
-      mockWin = merge(mocks.createFakeWindow('http://example.com'), renderingMocks().getWindowObject());
+      mockWin = merge(mocks.createFakeWindow(ORIGIN), renderingMocks().getWindowObject());
       ucTagData = {
         adId: '123',
         adServerDomain: 'mypub.com',
         pubUrl: ORIGIN,
       };
+      eventSource = null;
+
       renderCrossDomain(mockWin, ucTagData.adId, ucTagData.adServerDomain, ucTagData.pubUrl);
 
     });
 
-    afterEach(function() {
+    afterEach(function () {
       parseStub.restore();
       iframeStub.restore();
       triggerPixelSpy.restore();
@@ -110,7 +110,7 @@ describe('renderingManager', function() {
     function mockPrebidResponse(msg)  {
       mockWin.postMessage({
         origin: ORIGIN,
-        message: JSON.stringify(Object.assign({message: 'Prebid Response'}, msg))
+        message: JSON.stringify(Object.assign({ message: 'Prebid Response' }, msg))
       });
     }
 
@@ -147,13 +147,13 @@ describe('renderingManager', function() {
             info: {
               reason: 'preventWritingOnMainDocument'
             }
-          })
+          });
         });
 
         it('on ads that have no markup or adUrl', () => {
           mockPrebidResponse({
             adId: '123',
-          })
+          });
           expectEventMessage({
             adId: '123',
             event: RENDER_FAILED,
@@ -165,7 +165,7 @@ describe('renderingManager', function() {
 
         it('on exceptions', () => {
           iframeStub.callsFake(() => {
-            throw new Error()
+            throw new Error();
           });
           mockPrebidResponse({
             adId: '123',
@@ -179,7 +179,7 @@ describe('renderingManager', function() {
               reason: 'exception'
             }
           });
-        })
+        });
       });
       describe('should post AD_RENDER_SUCCEEDED', () => {
         it('on ad with markup', () => {