Skip to content

Commit d6450d1

Browse files
dgirardidgirardi
committed
weborama: remove appnexus specific handling
1 parent 736b20f commit d6450d1

File tree

2 files changed

+11
-94
lines changed

2 files changed

+11
-94
lines changed

‎modules/weboramaRtdProvider.js

Lines changed: 8 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -94,34 +94,25 @@
9494
* @typedef {WeboCtxConf|WeboUserDataConf|SfbxLiteDataConf} CommonConf
9595
*/
9696

97-
import {
98-
getGlobal
99-
} from '../src/prebidGlobal.js';
97+
import {getGlobal} from '../src/prebidGlobal.js';
10098
import {
10199
deepClone,
102100
deepSetValue,
101+
isArray,
102+
isBoolean,
103103
isEmpty,
104104
isFn,
105+
isPlainObject,
106+
isStr,
105107
logError,
106108
logMessage,
107-
isArray,
108-
isStr,
109-
isBoolean,
110-
isPlainObject,
111109
logWarn,
112110
mergeDeep,
113111
tryAppendQueryString
114112
} from '../src/utils.js';
115-
import {
116-
submodule
117-
} from '../src/hook.js';
118-
import {
119-
ajax
120-
} from '../src/ajax.js';
121-
import {
122-
getStorageManager
123-
} from '../src/storageManager.js';
124-
import adapterManager from '../src/adapterManager.js';
113+
import {submodule} from '../src/hook.js';
114+
import {ajax} from '../src/ajax.js';
115+
import {getStorageManager} from '../src/storageManager.js';
125116
import {MODULE_TYPE_RTD} from '../src/activities/modules.js';
126117

127118
/** @type {string} */
@@ -682,16 +673,6 @@ class WeboramaRtdProvider {
682673
// eslint-disable-next-line no-dupe-class-members
683674
#handleBid(reqBidsConfigObj, bid, profile, metadata) {
684675
this.#handleBidViaORTB2(reqBidsConfigObj, bid.bidder, profile, metadata);
685-
686-
/** @type {Object.<string,string>} */
687-
const bidderAliasRegistry = adapterManager.aliasRegistry || {};
688-
689-
/** @type {string} */
690-
const bidder = bidderAliasRegistry[bid.bidder] || bid.bidder;
691-
692-
if (bidder == 'appnexus') {
693-
this.#handleAppnexusBid(reqBidsConfigObj, bid, profile);
694-
}
695676
}
696677

697678
/** function that handles bid request data

‎test/spec/modules/weboramaRtdProvider_spec.js

Lines changed: 3 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,7 @@ describe('weboramaRtdProvider', function() {
130130
});
131131

132132
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
133-
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
134-
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
135-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
136-
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
133+
expect(reqBidsConfigObj.adUnits[0].bids.find((bid) => bid.params)).to.not.exist;
137134
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
138135
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
139136
site: {
@@ -217,10 +214,7 @@ describe('weboramaRtdProvider', function() {
217214
});
218215

219216
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
220-
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
221-
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
222-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
223-
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
217+
expect(reqBidsConfigObj.adUnits[0].bids.find((bid) => bid.params)).to.not.exist;
224218
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
225219
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
226220
site: {
@@ -303,11 +297,7 @@ describe('weboramaRtdProvider', function() {
303297
'adunit1': data,
304298
});
305299

306-
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
307-
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
308-
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
309-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
310-
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
300+
expect(reqBidsConfigObj.adUnits[0].bids.find((bid) => bid.params)).to.not.exist;
311301
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
312302
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
313303
site: {
@@ -539,10 +529,6 @@ describe('weboramaRtdProvider', function() {
539529

540530
reqBidsConfigObj.adUnits.forEach(adUnit => {
541531
expect(adUnit.bids.length).to.equal(5);
542-
expect(adUnit.bids[0].params).to.be.undefined;
543-
expect(adUnit.bids[1].params).to.be.undefined;
544-
expect(adUnit.bids[2].params.keywords).to.deep.equal(data);
545-
expect(adUnit.bids[3].params).to.be.undefined;
546532
});
547533
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
548534
if (v == 'appnexus') {
@@ -665,15 +651,8 @@ describe('weboramaRtdProvider', function() {
665651

666652
reqBidsConfigObj.adUnits.forEach(adUnit => {
667653
expect(adUnit.bids.length).to.equal(5);
668-
expect(adUnit.bids[0].params).to.be.undefined;
669-
expect(adUnit.bids[1].params).to.be.undefined;
670-
expect(adUnit.bids[3].params).to.be.undefined;
671-
expect(adUnit.bids[4].ortb2).to.be.undefined;
672654
});
673655

674-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
675-
expect(reqBidsConfigObj.adUnits[1].bids[2].params).to.be.undefined;
676-
677656
expect(onDataResponse).to.deep.equal({
678657
data: data,
679658
meta: {
@@ -811,9 +790,6 @@ describe('weboramaRtdProvider', function() {
811790
expect(adUnit.bids.length).to.equal(5);
812791
expect(adUnit.bids[0].params.target).to.equal('foo=bar');
813792
expect(adUnit.bids[1].params.dctr).to.equal('foo=bar');
814-
expect(adUnit.bids[2].params.keywords).to.deep.equal({
815-
foo: ['bar']
816-
});
817793
expect(adUnit.bids[3].params).to.deep.equal({
818794
inventory: {
819795
foo: 'bar',
@@ -1122,11 +1098,6 @@ describe('weboramaRtdProvider', function() {
11221098
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
11231099
expect(reqBidsConfigObj.adUnits[0].bids[0].params.target).to.equal('foo=bar');
11241100
expect(reqBidsConfigObj.adUnits[0].bids[1].params.dctr).to.equal('foo=bar');
1125-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal({
1126-
foo: ['bar'],
1127-
webo_ctx: ['foo', 'bar'],
1128-
webo_ds: ['baz'],
1129-
});
11301101
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.deep.equal({
11311102
inventory: {
11321103
foo: 'bar',
@@ -1213,7 +1184,6 @@ describe('weboramaRtdProvider', function() {
12131184
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
12141185
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
12151186
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
1216-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(defaultProfile);
12171187
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
12181188
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
12191189
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
@@ -1360,12 +1330,6 @@ describe('weboramaRtdProvider', function() {
13601330
}
13611331
});
13621332
})
1363-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal({
1364-
webo_ctx: ['foo', 'bar'],
1365-
webo_ds: ['baz'],
1366-
webo_bar: ['baz'],
1367-
});
1368-
expect(reqBidsConfigObj.adUnits[1].bids[2].params.keywords).to.deep.equal(data);
13691333

13701334
expect(onDataResponse).to.deep.equal({
13711335
data: data,
@@ -1446,7 +1410,6 @@ describe('weboramaRtdProvider', function() {
14461410
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
14471411
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
14481412
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
1449-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
14501413
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
14511414
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
14521415
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
@@ -1572,7 +1535,6 @@ describe('weboramaRtdProvider', function() {
15721535
expect(adUnit.bids.length).to.equal(5);
15731536
expect(adUnit.bids[0].params).to.be.undefined;
15741537
expect(adUnit.bids[1].params).to.be.undefined;
1575-
expect(adUnit.bids[2].params.keywords).to.deep.equal(data);
15761538
expect(adUnit.bids[3].params).to.be.undefined;
15771539
});
15781540
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
@@ -1716,7 +1678,6 @@ describe('weboramaRtdProvider', function() {
17161678
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.be.undefined;
17171679
})
17181680

1719-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
17201681
expect(reqBidsConfigObj.adUnits[1].bids[2].params).to.be.undefined;
17211682

17221683
expect(onDataResponse).to.deep.equal({
@@ -2172,11 +2133,6 @@ describe('weboramaRtdProvider', function() {
21722133
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
21732134
expect(reqBidsConfigObj.adUnits[0].bids[0].params.target).to.equal('foo=bar');
21742135
expect(reqBidsConfigObj.adUnits[0].bids[1].params.dctr).to.equal('foo=bar');
2175-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal({
2176-
foo: ['bar'],
2177-
webo_cs: ['foo', 'bar'],
2178-
webo_audiences: ['baz'],
2179-
});
21802136
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.deep.equal({
21812137
inventory: {
21822138
foo: 'bar',
@@ -2250,7 +2206,6 @@ describe('weboramaRtdProvider', function() {
22502206
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
22512207
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
22522208
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
2253-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(defaultProfile);
22542209
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
22552210
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
22562211
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
@@ -2324,7 +2279,6 @@ describe('weboramaRtdProvider', function() {
23242279
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
23252280
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
23262281
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
2327-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(defaultProfile);
23282282
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
23292283
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
23302284
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
@@ -2552,7 +2506,6 @@ describe('weboramaRtdProvider', function() {
25522506
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
25532507
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
25542508
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
2555-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
25562509
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
25572510
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
25582511
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
@@ -2677,7 +2630,6 @@ describe('weboramaRtdProvider', function() {
26772630
expect(adUnit.bids.length).to.equal(5);
26782631
expect(adUnit.bids[0].params).to.be.undefined;
26792632
expect(adUnit.bids[1].params).to.be.undefined;
2680-
expect(adUnit.bids[2].params.keywords).to.deep.equal(data);
26812633
expect(adUnit.bids[3].params).to.be.undefined;
26822634
});
26832635
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
@@ -2806,7 +2758,6 @@ describe('weboramaRtdProvider', function() {
28062758
expect(adUnit.bids[3].params).to.be.undefined;
28072759
});
28082760

2809-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
28102761
expect(reqBidsConfigObj.adUnits[1].bids[2].params).to.be.undefined;
28112762

28122763
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
@@ -3278,11 +3229,6 @@ describe('weboramaRtdProvider', function() {
32783229
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
32793230
expect(reqBidsConfigObj.adUnits[0].bids[0].params.target).to.equal('foo=bar');
32803231
expect(reqBidsConfigObj.adUnits[0].bids[1].params.dctr).to.equal('foo=bar');
3281-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal({
3282-
foo: ['bar'],
3283-
lite_occupation: ['gérant', 'bénévole'],
3284-
lite_hobbies: ['sport', 'cinéma'],
3285-
});
32863232
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.deep.equal({
32873233
inventory: {
32883234
foo: 'bar',
@@ -3355,7 +3301,6 @@ describe('weboramaRtdProvider', function() {
33553301
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
33563302
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
33573303
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
3358-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(defaultProfile);
33593304
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
33603305
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
33613306
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
@@ -3428,7 +3373,6 @@ describe('weboramaRtdProvider', function() {
34283373
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
34293374
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
34303375
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
3431-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(defaultProfile);
34323376
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
34333377
expect(reqBidsConfigObj.ortb2Fragments.bidder.other).to.deep.equal({
34343378
site: {
@@ -3515,7 +3459,6 @@ describe('weboramaRtdProvider', function() {
35153459
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
35163460
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
35173461
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
3518-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(defaultProfile);
35193462
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
35203463
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
35213464
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.deep.equal({
@@ -3663,13 +3606,6 @@ describe('weboramaRtdProvider', function() {
36633606
});
36643607
})
36653608

3666-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal({
3667-
lite_occupation: ['gérant', 'bénévole'],
3668-
lite_hobbies: ['sport', 'cinéma'],
3669-
lito_bar: ['baz'],
3670-
});
3671-
expect(reqBidsConfigObj.adUnits[1].bids[2].params.keywords).to.deep.equal(data);
3672-
36733609
expect(onDataResponse).to.deep.equal({
36743610
data: data,
36753611
meta: {

0 commit comments

Comments
 (0)