Skip to content

Commit 919540a

Browse files
committed
try fix appnexus case
1 parent e2c5747 commit 919540a

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

modules/weboramaRtdProvider.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,9 +719,10 @@ class WeboramaRtdProvider {
719719
*/
720720
// eslint-disable-next-line no-dupe-class-members
721721
#handleAppnexusBid(reqBidsConfigObj, bid, profile, metadata) {
722-
this.#assignProfileToObject(bid, 'params.keywords', profile);
723722
if (metadata.user) {
724723
this.#setBidderOrtb2(reqBidsConfigObj.ortb2Fragments?.bidder, bid.bidder, 'user.keywords', profile);
724+
} else {
725+
this.#assignProfileToObject(bid, 'params.keywords', profile);
725726
}
726727
}
727728

test/spec/modules/weboramaRtdProvider_spec.js

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1446,7 +1446,7 @@ describe('weboramaRtdProvider', function() {
14461446
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
14471447
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
14481448
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
1449-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
1449+
expect(reqBidsConfigObj.adUnits[0].bids[2].params).to.be.undefined;
14501450
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
14511451
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
14521452
if (v == 'appnexus') {
@@ -1585,7 +1585,7 @@ describe('weboramaRtdProvider', function() {
15851585
expect(adUnit.bids.length).to.equal(5);
15861586
expect(adUnit.bids[0].params).to.be.undefined;
15871587
expect(adUnit.bids[1].params).to.be.undefined;
1588-
expect(adUnit.bids[2].params.keywords).to.deep.equal(data);
1588+
expect(adUnit.bids[2].params).to.be.undefined;
15891589
expect(adUnit.bids[3].params).to.be.undefined;
15901590
});
15911591
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
@@ -1712,6 +1712,7 @@ describe('weboramaRtdProvider', function() {
17121712
expect(adUnit.bids.length).to.equal(5);
17131713
expect(adUnit.bids[0].params).to.be.undefined;
17141714
expect(adUnit.bids[1].params).to.be.undefined;
1715+
expect(adUnit.bids[2].params).to.be.undefined;
17151716
expect(adUnit.bids[3].params).to.be.undefined;
17161717
});
17171718
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
@@ -1731,9 +1732,6 @@ describe('weboramaRtdProvider', function() {
17311732
expect(reqBidsConfigObj.ortb2Fragments.bidder[v]).to.be.undefined;
17321733
})
17331734

1734-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(data);
1735-
expect(reqBidsConfigObj.adUnits[1].bids[2].params).to.be.undefined;
1736-
17371735
expect(onDataResponse).to.deep.equal({
17381736
data: data,
17391737
meta: {
@@ -2189,8 +2187,6 @@ describe('weboramaRtdProvider', function() {
21892187
expect(reqBidsConfigObj.adUnits[0].bids[1].params.dctr).to.equal('foo=bar');
21902188
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal({
21912189
foo: ['bar'],
2192-
webo_cs: ['foo', 'bar'],
2193-
webo_audiences: ['baz'],
21942190
});
21952191
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.deep.equal({
21962192
inventory: {
@@ -2278,7 +2274,7 @@ describe('weboramaRtdProvider', function() {
22782274
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
22792275
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
22802276
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
2281-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(defaultProfile);
2277+
expect(reqBidsConfigObj.adUnits[0].bids[2].params).to.be.undefined;
22822278
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
22832279
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
22842280
if (v == 'appnexus') {
@@ -2365,7 +2361,7 @@ describe('weboramaRtdProvider', function() {
23652361
expect(reqBidsConfigObj.adUnits[0].bids.length).to.equal(5);
23662362
expect(reqBidsConfigObj.adUnits[0].bids[0].params).to.be.undefined;
23672363
expect(reqBidsConfigObj.adUnits[0].bids[1].params).to.be.undefined;
2368-
expect(reqBidsConfigObj.adUnits[0].bids[2].params.keywords).to.deep.equal(defaultProfile);
2364+
expect(reqBidsConfigObj.adUnits[0].bids[2].params).to.be.undefined;
23692365
expect(reqBidsConfigObj.adUnits[0].bids[3].params).to.be.undefined;
23702366
['smartadserver', 'pubmatic', 'appnexus', 'rubicon', 'other'].forEach((v) => {
23712367
if (v == 'appnexus') {
@@ -2653,7 +2649,7 @@ describe('weboramaRtdProvider', function() {
26532649

26542650
Object.keys(testcases).forEach(label => {
26552651
const sendToBidders = testcases[label];
2656-
it(`check sendToBidders as ${label}`, function() {
2652+
it(`check sendToBidders as '${label}'`, function() {
26572653
let onDataResponse = {};
26582654
const moduleConfig = {
26592655
params: {

0 commit comments

Comments
 (0)