Skip to content

Remove PYTHON_VERSION_JUPYTER and default Jupyter installs to the primary or alternate Python version #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ianpittwood opened this issue Aug 9, 2023 · 1 comment
Open

Remove PYTHON_VERSION_JUPYTER and default Jupyter installs to the primary or alternate Python version #614

ianpittwood opened this issue Aug 9, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers tech debt Technical debt we should address workbench Specific to workbench images

Comments

@ianpittwood
Copy link
Collaborator

ianpittwood commented Aug 9, 2023 •
edited by bschwedler
Loading

Closes #613

Relates to #590

Having PYTHON_VERSION_JUPYTER as a separate version can be confusing to end users since that variable does not specifically install a different version, it only references a that version for the path used when creating the Jupyter sandbox virtual environment. We should create a convention for Jupyter to always use the primary or alternate Python and update all projects accordingly.

          This confused me, as I thought that it was a third installation of python. Why are we explicitly setting this? Why isn't it just always presumed to be installed at PYTHON_VERSION?

Originally posted by @msarahan in #564 (comment)
@ianpittwood ianpittwood mentioned this issue Aug 9, 2023
Merged
@ianpittwood ianpittwood added enhancement New feature or request good first issue Good for newcomers workbench Specific to workbench images tech debt Technical debt we should address labels Aug 9, 2023
@ianpittwood ianpittwood mentioned this issue Aug 9, 2023
Merged
@bschwedler
Copy link
Contributor

I really like this approach. The more variables we can get rid of, the better!

@ianpittwood ianpittwood mentioned this issue Aug 9, 2023
Closed
@bschwedler bschwedler mentioned this issue Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers tech debt Technical debt we should address workbench Specific to workbench images
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bschwedler @ianpittwood