Skip to content

Commit c746672

Browse files
Merge pull request #880 from rstudio/enable-workbench-session-init-release-build
Enable workbench-session-init release target
2 parents dc33896 + 052e998 commit c746672

File tree

3 files changed

+3
-39
lines changed

3 files changed

+3
-39
lines changed

.github/workflows/build-bake.yaml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,6 @@ jobs:
333333
snyk-token: '${{ secrets.SNYK_TOKEN }}'
334334

335335
workbench-session-init:
336-
if: false # TODO: Re-enable this job after next release
337336
needs: [setup]
338337
name: Workbench Session Init
339338
runs-on: ubuntu-latest-8x
@@ -363,28 +362,7 @@ jobs:
363362
with:
364363
buildkitd-config: ./share/buildkitd.toml
365364

366-
- name: Set up Just
367-
uses: extractions/setup-just@v2
368-
env:
369-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
370-
371-
- uses: actions/setup-python@v5
372-
with:
373-
python-version: '3.12'
374-
375-
- name: Install Python dependencies
376-
run: |
377-
pip install requests
378-
379-
- name: Get Version
380-
id: get-version
381-
run: |
382-
WORKBENCH_SESSION_INIT_VERSION=$(just -f ci.Justfile get-version workbench --type=daily --local)
383-
echo "WORKBENCH_SESSION_INIT_VERSION=$WORKBENCH_SESSION_INIT_VERSION" >> $GITHUB_OUTPUT
384-
385365
- name: Build, Test, and Push
386-
env:
387-
WORKBENCH_SESSION_INIT_VERSION: ${{ steps.get-version.outputs.WORKBENCH_SESSION_INIT_VERSION }}
388366
uses: ./.github/actions/bake-test-push
389367
with:
390368
target: ${{ env.target }}

Justfile

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,13 +49,8 @@ delete-builder:
4949
alias build := bake
5050
# just bake workbench-images
5151
bake target="default":
52-
#!/bin/bash
5352
just -f {{justfile()}} create-builder || true
54-
if [ -z "$WORKBENCH_SESSION_INIT_VERSION" ]; then
55-
WORKBENCH_SESSION_INIT_VERSION=$(just -f ci.Justfile get-version workbench --type=daily --local)
56-
fi
5753
GIT_SHA=$(git rev-parse --short HEAD) \
58-
WORKBENCH_SESSION_INIT_VERSION=${WORKBENCH_SESSION_INIT_VERSION} \
5954
docker buildx bake --builder=posit-builder -f docker-bake.hcl {{target}}
6055

6156
# just preview-bake workbench-images dev
@@ -93,12 +88,7 @@ preview-plan branch="$(git branch --show-current)":
9388

9489
# just test workbench
9590
test target="default" file="docker-bake.hcl":
96-
#!/bin/bash
97-
if [ -z "$WORKBENCH_SESSION_INIT_VERSION" ]; then
98-
WORKBENCH_SESSION_INIT_VERSION=$(just -f ci.Justfile get-version workbench --type=daily --local)
99-
fi
10091
GIT_SHA=$(git rev-parse --short HEAD) \
101-
WORKBENCH_SESSION_INIT_VERSION=${WORKBENCH_SESSION_INIT_VERSION} \
10292
python3 {{justfile_directory()}}/tools/test_bake_artifacts.py --target "{{target}}" --file "{{file}}"
10393

10494
# just preview-test connect dev

docker-bake.hcl

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@ variable WORKBENCH_VERSION {
1111
default = "2024.12.0+467.pro1"
1212
}
1313

14-
variable WORKBENCH_SESSION_INIT_VERSION {
15-
default = ""
16-
}
17-
1814
variable DRIVERS_VERSION {
1915
default = "2024.03.0"
2016
}
@@ -500,16 +496,16 @@ target "workbench-session-init" {
500496
inherits = ["base"]
501497
target = "build"
502498

503-
name = "workbench-session-init-${builds.os}-${replace(tag_safe_version(WORKBENCH_SESSION_INIT_VERSION), ".", "-")}"
504-
tags = get_tags(builds.os, "workbench-session-init", WORKBENCH_SESSION_INIT_VERSION)
499+
name = "workbench-session-init-${builds.os}-${replace(tag_safe_version(WORKBENCH_VERSION), ".", "-")}"
500+
tags = get_tags(builds.os, "workbench-session-init", WORKBENCH_VERSION)
505501

506502
dockerfile = "Dockerfile.${builds.os}"
507503
context = "workbench-session-init"
508504

509505
matrix = WORKBENCH_SESSION_INIT_BUILD_MATRIX
510506

511507
args = {
512-
RSW_VERSION = WORKBENCH_SESSION_INIT_VERSION
508+
RSW_VERSION = WORKBENCH_VERSION
513509
}
514510
}
515511

0 commit comments

Comments
 (0)