RC 1.4.1 (#864)

* Escalation deprecation of legacy functions

* Update NEWS, README, etc

* Do not evaluate code in vignette for updating

* Update tests

* Run revdepcheck

* Update NEWS

* Don't run deprecated examples

* Try to skip some examples in the action to check across boards

* Increment version number to 1.4.1

Author: juliasilge

.github/workflows/check-boards.yaml

@@ -14,6 +14,8 @@ jobs:
     env:
       GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
       R_KEEP_PKG_SOURCE: yes
+      # To avoid running `board_url()` examples that result in 529 errors on GH
+      NOT_CRAN: false
 
       # board specific env vars
       PINS_AZURE_SAS: ${{ secrets.PINS_AZURE_SAS }}

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: pins
 Title: Pin, Discover, and Share Resources
-Version: 1.4.0.9000
+Version: 1.4.1
 Authors@R: c(
     person("Julia", "Silge", , "[email protected]", role = c("cre", "aut"),
            comment = c(ORCID = "0000-0002-3671-836X")),

NEWS.md

@@ -1,15 +1,17 @@
-# pins (development version)
+# pins 1.4.1
 
 * Support new `preview_data` parameter for pin previews on Posit Connect (#850).
 
 * Fixed a bug in how `pin_upload()` handles pin names (#852).
 
 * Improved documentation for S3-compatible object storage (#853).
 
-* Prepends 'https://' to Databricks host if missing (#855).
+* Prepend 'https://' to Databricks host if missing (#855).
 
 * Fixed handling of `rsconnect::accounts()` results (#861).
 
+* Escalated gradual deprecation process for legacy pins functions such as `pin()` (#864).
+
 # pins 1.4.0
 
 ## Lifecycle changes

R/legacy_azure.R

@@ -2,7 +2,7 @@
 #'
 #' @description
 #' `r lifecycle::badge('deprecated')`
-#' 
+#'
 #' To use Microsoft Azure Storage as a board, you'll need an Azure Storage
 #' account, an Azure Storage container, and an Azure Storage key.
 #' @inheritParams legacy_datatxt
@@ -27,14 +27,17 @@
 #' @export
 #' @keywords internal
 legacy_azure <- function(
-                        container = Sys.getenv("AZURE_STORAGE_CONTAINER"),
-                        account = Sys.getenv("AZURE_STORAGE_ACCOUNT"),
-                        key = Sys.getenv("AZURE_STORAGE_KEY"),
-                        cache = NULL,
-                        name = "azure",
-                        ...) {
-  if (nchar(container) == 0) stop("The 'azure' board requires a 'container' parameter.")
-  if (nchar(account) == 0) stop("The 'azure' board requires an 'account' parameter.")
+  container = Sys.getenv("AZURE_STORAGE_CONTAINER"),
+  account = Sys.getenv("AZURE_STORAGE_ACCOUNT"),
+  key = Sys.getenv("AZURE_STORAGE_KEY"),
+  cache = NULL,
+  name = "azure",
+  ...
+) {
+  if (nchar(container) == 0)
+    stop("The 'azure' board requires a 'container' parameter.")
+  if (nchar(account) == 0)
+    stop("The 'azure' board requires an 'account' parameter.")
   if (nchar(key) == 0) stop("The 'azure' board requires a 'key' parameter.")
 
   azure_url <- paste0("https://", account, ".blob.core.windows.net/", container)
@@ -56,14 +59,16 @@ legacy_azure <- function(
 
 #' @rdname legacy_azure
 #' @export
-board_register_azure <- function(name = "azure",
-                                 container = Sys.getenv("AZURE_STORAGE_CONTAINER"),
-                                 account = Sys.getenv("AZURE_STORAGE_ACCOUNT"),
-                                 key = Sys.getenv("AZURE_STORAGE_KEY"),
-                                 cache = NULL,
-                                 path = NULL,
-                                 ...) {
-  lifecycle::deprecate_soft(
+board_register_azure <- function(
+  name = "azure",
+  container = Sys.getenv("AZURE_STORAGE_CONTAINER"),
+  account = Sys.getenv("AZURE_STORAGE_ACCOUNT"),
+  key = Sys.getenv("AZURE_STORAGE_KEY"),
+  cache = NULL,
+  path = NULL,
+  ...
+) {
+  lifecycle::deprecate_warn(
     "1.4.0",
     "board_register_azure()",
     details = 'Learn more at <https://pins.rstudio.com/articles/pins-update.html>'
@@ -120,7 +125,10 @@ azure_headers <- function(board, verb, path, file) {
     sep = "\n"
   )
 
-  signature <- openssl::sha256(charToRaw(content), key = jsonlite::base64_dec(board$key)) %>%
+  signature <- openssl::sha256(
+    charToRaw(content),
+    key = jsonlite::base64_dec(board$key)
+  ) %>%
     jsonlite::base64_enc()
 
   headers <- httr::add_headers(

R/legacy_board_registry.R

@@ -18,11 +18,13 @@
 #' board %>% pin_read("mtcars")
 #' @keywords internal
 #' @export
-board_register <- function(board,
-                           name = NULL,
-                           cache = NULL,
-                           versions = NULL,
-                           ...) {
+board_register <- function(
+  board,
+  name = NULL,
+  cache = NULL,
+  versions = NULL,
+  ...
+) {
   if (is_url(board)) {
     board <- legacy_datatxt(
       name = name,
@@ -34,10 +36,20 @@ board_register <- function(board,
   } else {
     fun <- paste0("board_register_", board)
     if (!exists(fun, mode = "function")) {
-      stop("Don't know how to create board of type '", board, "'", call. = FALSE)
+      stop(
+        "Don't know how to create board of type '",
+        board,
+        "'",
+        call. = FALSE
+      )
     }
     fun <- match.fun(fun)
-    board <- fun(name = name %||% board, cache = cache, versions = versions, ...)
+    board <- fun(
+      name = name %||% board,
+      cache = cache,
+      versions = versions,
+      ...
+    )
   }
 
   board_register2(board)
@@ -47,14 +59,16 @@ board_register <- function(board,
 
 #' @rdname board_register
 #' @export
-board_register_rsconnect <- function(name = "rsconnect",
-                                     server = NULL,
-                                     account = NULL,
-                                     key = NULL,
-                                     output_files = FALSE,
-                                     cache = NULL,
-                                     ...) {
-  lifecycle::deprecate_soft(
+board_register_rsconnect <- function(
+  name = "rsconnect",
+  server = NULL,
+  account = NULL,
+  key = NULL,
+  output_files = FALSE,
+  cache = NULL,
+  ...
+) {
+  lifecycle::deprecate_warn(
     "1.4.0",
     "board_register_rsconnect()",
     details = 'Learn more at <https://pins.rstudio.com/articles/pins-update.html>'
@@ -88,7 +102,10 @@ board_register_code <- function(board, name) {
     parent_call <- sys.call(sys.parent(parent_idx))
     if (!is.function(parent_func) || !is.call(parent_call)) break
 
-    this_parent_call <- tryCatch(match.call(definition = parent_func, call = parent_call), error = function(e) NULL)
+    this_parent_call <- tryCatch(
+      match.call(definition = parent_func, call = parent_call),
+      error = function(e) NULL
+    )
 
     if (is.null(this_parent_call)) break
     if (length(this_parent_call) < 1) break
@@ -105,8 +122,7 @@ board_register_code <- function(board, name) {
   header <- if (grepl("^pins::", function_name)) "" else "library(pins)\n"
   if (is.null(parent_call)) {
     paste0(header, "board_register(\"", board, "\", name = \"", name, "\")")
-  }
-  else {
+  } else {
     main_call <- paste(deparse(parent_call, width.cutoff = 500), collapse = " ")
     paste0(header, main_call)
   }
@@ -115,7 +131,8 @@ board_register_code <- function(board, name) {
 #' @rdname board_register
 #' @export
 board_deregister <- function(name, ...) {
-  if (!name %in% board_registry_list()) stop("Board '", name, "' is not registered.")
+  if (!name %in% board_registry_list())
+    stop("Board '", name, "' is not registered.")
 
   board <- board_get(name)
   board_registry_set(name, NULL)
@@ -151,7 +168,12 @@ board_get <- function(name) {
     } else if (name %in% board_list()) {
       board_registry_get(name)
     } else {
-      stop("Board '", name, "' not a board, available boards: ", paste(board_list(), collapse = ", "))
+      stop(
+        "Board '",
+        name,
+        "' not a board, available boards: ",
+        paste(board_list(), collapse = ", ")
+      )
     }
   } else {
     stop("Invalid board specification", call. = FALSE)