Skip to content

Handle FindOGRE module's differing definitions #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Handle FindOGRE module's differing definitions #1574

wants to merge 3 commits into from

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Dec 18, 2020

The FindOGRE CMake module sets separate include directory values for each component, so if OGRE is found using this mechanism, we need to list those directories as well.

For reference, here is where FindOGRE sets the per-component include directories: https://github.com/OGRECave/ogre/blob/7eaa819fb722838b0b981f2bc505726c5ee05348/CMake/Packages/FindOGRE.cmake#L468

The FindOGRE CMake module sets separate include directory values for
each component, so if OGRE is found using this mechanism, we need to
list those directories as well.
...Also need to handle the OGRE_*_LIBRARIES values.
@rhaschke
Copy link
Contributor

Which version of OGRE you are compiling against that you observe issues with? I didn't notice any issues so far.
Also, I would expect that libs and includes for all components are accumulated in OGRE_LIBRARIES and OGRE_INCLUDE_DIRS variables. At least that's the behaviour I'm used to for catkin and Boost.

@cottsay
Copy link
Member Author

cottsay commented Jan 20, 2021

Which version of OGRE you are compiling against that you observe issues with?

Any OGRE version prior to 1.11 could contain FindOGRE.cmake and manifest this issue. Fedora 33 packages 1.9, which is where I hit this issue.

@rhaschke
Copy link
Contributor

Ubuntu, the reference distro for ROS, also ships OGRE 1.9 - and we didn't observe any issues in the past. Oh, wait: On Ubuntu, the cmake files are installed in a non-standard location and thus are not found automatically. Thus we fallback to pkgconfig!

I fixed this issue in 65ea752 in a way to be compatible with more recent versions of OGRE, where all include dirs and libraries are collected in OGRE_INCLUDE_DIRS and OGRE_LIBRARIES variables resp.

@rhaschke rhaschke closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants