PropertyTree: set custom SelectionModel only with valid model #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be a corner-case one might actually call a bug in qt5. the `setSelectionModel(new PropertySelectionModel(nullptr))` call complains that the SelectionModel and the PropertyTreeView use different models, although both are set to nullptr in user code. Qt actually sets the model of QAbstractItemView to the dummy `QAbstractItemModelPrivate::staticEmptyModel`, but the SelectionModel is actually initialized with `nullptr`.
|
@v4hn: What are you doing? |
v4hn
changed the title
|
This was |
|
I just updated the description and target branch. |
|
How severe is this issue? Is Qt just printing a warning or is it crashing? |
|
How severe is this issue? Is Qt just printing a warning or is it crashing?
It prints two lines to stderr per call with nullptr input.
For the motion planning display that's 6-8 lines of output.
Behavior is not affected.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a corner-case one might actually call a bug in qt5.
the
setSelectionModel(new PropertySelectionModel(nullptr))callcomplains that the SelectionModel and the PropertyTreeView use different
models, although both are set to nullptr in user code.
Qt actually sets the model of QAbstractItemView to
the dummy
QAbstractItemModelPrivate::staticEmptyModel, but theSelectionModel is actually initialized with
nullptr.