ImageDisplay: report frame issues #1425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming you mean "should we support them", then I'd say, without looking into it much, yes. It seems like something that doesn't change often and therefore is a prime candidate for latching.
That seems like a reasonable thing to do. It would be nice if there was a "on fixed frame changed" callback that displays could implement. Then the |
rhaschke
force-pushed
the
image-display-tf-failures
branch
from
0c16658 to
84af9dd
Compare
rhaschke
force-pushed
the
image-display-tf-failures
branch
from
84af9dd to
26ab78e
Compare
CameraInfos are often published via latched topics. In this case, the MessageFilter will only receive a single message and thus never issues a failure callback in case the frame is wrong. This is because, MessageFilter processes its queue only if a new message arrives.
rhaschke
force-pushed
the
image-display-tf-failures
branch
from
26ab78e to
f8fa98b
Compare
rhaschke
added a commit
that referenced
this pull request
Sep 29, 2019
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Sep 29, 2019
rhaschke
added a commit
to rhaschke/rviz
that referenced
this pull request
Sep 29, 2019
- remove unused caminfo_tf_filter_ - integrate clean() into reset() - remove unused updateStatus()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, image displays report "no image received" - also in case images were received but had an unknown image frame. This PR adds a corresponding failure handling for TF frames.
However, for
ImageDisplayan issue remains withCameraInfo: If the camera info is published latched, rviz only receives a single message (either success or failure depending on the frame status). If rviz' fixed frame changes (which probably changes the frame status of the camera as well), this change is not noticed anymore, because updates can only happen when a new TF message is received.@wjwwood, hence my question: Should we latched CameraInfo messages be supported?
If so, we would need to memorize the latest received message in any case and validate its frame "manually" as soon as the fixed frame changes.