checking text in TEXT_VIEW_FACING marker to prevent crashes

jgueldenstein · jgueldenstein · commit d30cda4ab14f · 2018-08-03T11:57:25.000+02:00
diff --git a/src/rviz/default_plugin/markers/text_view_facing_marker.cpp b/src/rviz/default_plugin/markers/text_view_facing_marker.cpp
@@ -57,6 +57,8 @@ void TextViewFacingMarker::onNewMessage(const MarkerConstPtr& old_message, const
 {
   ROS_ASSERT(new_message->type == visualization_msgs::Marker::TEXT_VIEW_FACING);
 
+  if(new_message->text.empty()|| new_message->text.find_first_not_of(" \t\n\v\f\r") == std::string::npos)
+    return;
   if (!text_)
   {
     text_ = new MovableText(new_message->text);

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ void TextViewFacingMarker::onNewMessage(const MarkerConstPtr& old_message, const`
`57`	`57`	`{`
`58`	`58`	`ROS_ASSERT(new_message->type == visualization_msgs::Marker::TEXT_VIEW_FACING);`
`59`	`59`
	`60`	`+ if(new_message->text.empty()\|\| new_message->text.find_first_not_of(" \t\n\v\f\r") == std::string::npos)`
	`61`	`+ return;`
`60`	`62`	`if (!text_)`
`61`	`63`	`{`
`62`	`64`	`text_ = new MovableText(new_message->text);`