Skip to content

Need a new release #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CAD97 opened this issue Apr 30, 2020 · 11 comments
Closed

Need a new release #218

CAD97 opened this issue Apr 30, 2020 · 11 comments
Labels
help wanted

Comments

@CAD97
Copy link
Contributor

CAD97 commented Apr 30, 2020

Specifically, unwrap_newtypes would be great to have for serialization as well as deserialization.

This is especially relevant because serde recommends the "unwrapped" newtype representation, and ron is the odd one out in considering them semantically meaningful.
@CAD97 CAD97 changed the title Serialization should support extensions (Pretty) Serialization should support extensions Apr 30, 2020
@CAD97
Copy link
Contributor Author

CAD97 commented Apr 30, 2020

..and I went to look at implementing this, and it's already implemented.

Could we get a new release with that code?

@CAD97
Copy link
Contributor Author

CAD97 commented Apr 30, 2020 •
edited
Loading

Sniffing: #182, 10 9 months ago added this.

@CAD97 CAD97 changed the title (Pretty) Serialization should support extensions 0.5.2 needs to be released Apr 30, 2020
@kvark
Copy link
Collaborator

kvark commented May 2, 2020

Based on your investigation in #196 (comment), I created a "v0.5" branch. You can make a PR that back-ports all the non-breaking changes you'd like to see in 0.5.2 towards this branch, and bump the patch version. I'll be happy to review the changes (for breakage) and publish.

@bpfoley
Copy link
Contributor

bpfoley commented May 11, 2020

I'd also like to see a release that depends on base64 0.12 (which is a compatibility change, and is implemented on master). Would it be worth jumping straight to 0.6?

@CAD97
Copy link
Contributor Author

CAD97 commented May 11, 2020 •
edited
Loading

Yeah, this issue is (now) no longer specifically about a new 0.5 release but just a release with the new progress since 0.5.1

@CAD97 CAD97 changed the title 0.5.2 needs to be released Need a new release May 11, 2020
@CAD97
Copy link
Contributor Author

CAD97 commented May 11, 2020

See also #196 which has some discussion about preparing for a 0.6.

@Boscop
Copy link

Boscop commented Nov 18, 2020

Any update on this? I'm also interested in unwrap_newtypes for serialization.

@kvark
Copy link
Collaborator

kvark commented Nov 18, 2020

I believe this has landed in 0.6

@kvark kvark closed this as completed Nov 18, 2020
@Boscop
Copy link

Boscop commented Nov 19, 2020

@kvark But unwrap_newtypes is not working for serialization. The serializer doesn't even check the flag.

@Boscop
Copy link

Boscop commented Nov 19, 2020

https://docs.rs/ron/0.6.2/src/ron/ser/mod.rs.html#240

@kvark
Copy link
Collaborator

kvark commented Nov 19, 2020

This issue is for the breaking 0.6 release, and it was done.

So the feature landed for deserializer only?
Filed #284 to follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kvark @Boscop @bpfoley @CAD97