Switch to interpreted delegates for one-off invocations

Closes dotnet#29814

Author: roji

src/EFCore.Cosmos/Query/Internal/CosmosSqlTranslatingExpressionVisitor.cs

@@ -995,7 +995,9 @@ private static SqlConstantExpression GetConstantOrNull(Expression expression)
         => CanEvaluate(expression)
             ? new SqlConstantExpression(
                 Expression.Constant(
-                    Expression.Lambda<Func<object>>(Expression.Convert(expression, typeof(object))).Compile().Invoke(),
+                    Expression.Lambda<Func<object>>(Expression.Convert(expression, typeof(object)))
+                        .Compile(preferInterpretation: true)
+                        .Invoke(),
                     expression.Type),
                 null)
             : null;

src/EFCore.InMemory/Query/Internal/InMemoryExpressionTranslatingExpressionVisitor.cs

@@ -1505,7 +1505,9 @@ when CanEvaluate(memberInitExpression):
 
     private static ConstantExpression GetValue(Expression expression)
         => Expression.Constant(
-            Expression.Lambda<Func<object>>(Expression.Convert(expression, typeof(object))).Compile().Invoke(),
+            Expression.Lambda<Func<object>>(Expression.Convert(expression, typeof(object)))
+                .Compile(preferInterpretation: true)
+                .Invoke(),
             expression.Type);
 
     private static bool CanEvaluate(Expression expression)
@@ -1518,7 +1520,7 @@ private static bool CanEvaluate(Expression expression)
                 return true;
 
             case NewExpression newExpression:
-                return newExpression.Arguments.All(e => CanEvaluate(e));
+                return newExpression.Arguments.All(CanEvaluate);
 
             case MemberInitExpression memberInitExpression:
                 return CanEvaluate(memberInitExpression.NewExpression)

src/EFCore.Relational/Metadata/Conventions/RelationalQueryFilterRewritingConvention.cs

@@ -84,7 +84,9 @@ protected override Expression VisitMethodCall(MethodCallExpression methodCallExp
                 else
                 {
                     var formattableString = Expression.Lambda<Func<FormattableString>>(
-                        Expression.Convert(methodCallExpression.Arguments[1], typeof(FormattableString))).Compile().Invoke();
+                            Expression.Convert(methodCallExpression.Arguments[1], typeof(FormattableString)))
+                        .Compile(preferInterpretation: true)
+                        .Invoke();
 
                     sql = formattableString.Format;
                     argument = Expression.Constant(formattableString.GetArguments());

src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs

@@ -1540,7 +1540,9 @@ private static Expression GetConstantOrNotTranslated(Expression expression)
         => CanEvaluate(expression)
             ? new SqlConstantExpression(
                 Expression.Constant(
-                    Expression.Lambda<Func<object>>(Expression.Convert(expression, typeof(object))).Compile().Invoke(),
+                    Expression.Lambda<Func<object>>(Expression.Convert(expression, typeof(object)))
+                        .Compile(preferInterpretation: true)
+                        .Invoke(),
                     expression.Type),
                 null)
             : QueryCompilationContext.NotTranslatedExpression;

src/EFCore/Query/Internal/ParameterExtractingExpressionVisitor.cs

@@ -151,8 +151,7 @@ protected override Expression VisitConditional(ConditionalExpression conditional
     {
         var newTestExpression = TryGetConstantValue(conditionalExpression.Test) ?? Visit(conditionalExpression.Test);
 
-        if (newTestExpression is ConstantExpression constantTestExpression
-            && constantTestExpression.Value is bool constantTestValue)
+        if (newTestExpression is ConstantExpression { Value: bool constantTestValue })
         {
             return constantTestValue
                 ? Visit(conditionalExpression.IfTrue)
@@ -227,8 +226,7 @@ protected override Expression VisitBinary(BinaryExpression binaryExpression)
     }
 
     private static bool ShortCircuitLogicalExpression(Expression expression, ExpressionType nodeType)
-        => expression is ConstantExpression constantExpression
-            && constantExpression.Value is bool constantValue
+        => expression is ConstantExpression { Value: bool constantValue }
             && ((constantValue && nodeType == ExpressionType.OrElse)
                 || (!constantValue && nodeType == ExpressionType.AndAlso));
 
@@ -265,7 +263,7 @@ private static Expression GenerateConstantExpression(object? value, Type returnT
 
         return constantExpression.Type != returnType
             ? Expression.Convert(constantExpression, returnType)
-            : (Expression)constantExpression;
+            : constantExpression;
     }
 
     private Expression Evaluate(Expression expression, bool generateParameter)
@@ -365,8 +363,7 @@ public ContextParameterReplacingExpressionVisitor(Type contextType)
     private static Expression RemoveConvert(Expression expression)
     {
         if (expression is UnaryExpression unaryExpression
-            && (expression.NodeType == ExpressionType.Convert
-                || expression.NodeType == ExpressionType.ConvertChecked))
+            && expression.NodeType is ExpressionType.Convert or ExpressionType.ConvertChecked)
         {
             return RemoveConvert(unaryExpression.Operand);
         }
@@ -436,18 +433,16 @@ private static Expression RemoveConvert(Expression expression)
                 parameterName = methodCallExpression.Method.Name;
                 break;
 
-            case UnaryExpression unaryExpression
-                when (unaryExpression.NodeType == ExpressionType.Convert
-                    || unaryExpression.NodeType == ExpressionType.ConvertChecked)
-                && (unaryExpression.Type.UnwrapNullableType() == unaryExpression.Operand.Type):
+            case UnaryExpression { NodeType: ExpressionType.Convert or ExpressionType.ConvertChecked } unaryExpression
+                when (unaryExpression.Type.UnwrapNullableType() == unaryExpression.Operand.Type):
                 return GetValue(unaryExpression.Operand, out parameterName);
         }
 
         try
         {
             return Expression.Lambda<Func<object>>(
                     Expression.Convert(expression, typeof(object)))
-                .Compile()
+                .Compile(preferInterpretation: true)
                 .Invoke();
         }
         catch (Exception exception)
@@ -611,7 +606,7 @@ protected override Expression VisitMethodCall(MethodCallExpression methodCallExp
         protected override Expression VisitMember(MemberExpression memberExpression)
         {
             _containsClosure = memberExpression.Expression != null
-                || !(memberExpression.Member is FieldInfo fieldInfo && fieldInfo.IsInitOnly);
+                || !(memberExpression.Member is FieldInfo { IsInitOnly: true });
             return base.VisitMember(memberExpression);
         }