[feat] improve performance of entity tree operations

Author: robinovitch61

internal/model/entity.go

@@ -19,18 +19,23 @@ type Entity struct {
 }
 
 func (e Entity) Render() linebuffer.LineBufferer {
+	return linebuffer.New(e.Repr())
+}
+
+// Repr is a faster equivalent to e.Render().Content()
+func (e Entity) Repr() string {
 	if e.IsCluster {
-		return linebuffer.New(e.Prefix + e.Container.Cluster)
+		return e.Prefix + e.Container.Cluster
 	} else if e.IsNamespace {
-		return linebuffer.New(e.Prefix + e.Container.Namespace)
+		return e.Prefix + e.Container.Namespace
 	} else if e.IsPodOwner {
 		res := e.Prefix + e.Container.PodOwner
 		if e.Container.PodOwnerMetadata.OwnerType != "" {
 			res += " <" + e.Container.PodOwnerMetadata.OwnerType + ">"
 		}
-		return linebuffer.New(res)
+		return res
 	} else if e.IsPod {
-		return linebuffer.New(e.Prefix + e.Container.Pod)
+		return e.Prefix + e.Container.Pod
 	} else {
 		// for containers
 		res := e.Prefix + e.State.StatusIndicator() + " " + e.Container.Name + " (" + e.Container.Status.State.String()
@@ -66,7 +71,7 @@ func (e Entity) Render() linebuffer.LineBufferer {
 		}
 
 		res += ")"
-		return linebuffer.New(res)
+		return res
 	}
 }
 

internal/model/entity_tree.go

@@ -323,7 +323,7 @@ func (et *entityTreeImpl) IsVisibleGivenFilter(entity Entity, filter filter.Mode
 		et.isVisibleCache = newIsVisibleCache(filter)
 	}
 
-	if filter.Matches(entity.Render().Content()) {
+	if filter.Matches(entity.Repr()) {
 		return et.isVisibleCache.SetAndReturn(entity, true)
 	}
 
@@ -338,13 +338,13 @@ func (et *entityTreeImpl) IsVisibleGivenFilter(entity Entity, filter filter.Mode
 
 	parent := et.getParentEntity(entity)
 	for !parent.EqualTo(Entity{}) {
-		if filter.Matches(parent.Render().Content()) {
+		if filter.Matches(parent.Repr()) {
 			return et.isVisibleCache.SetAndReturn(entity, true)
 		}
 		parent = et.getParentEntity(parent)
 	}
 
-	return et.isVisibleCache.SetAndReturn(entity, filter.Matches(parent.Render().Content()))
+	return et.isVisibleCache.SetAndReturn(entity, filter.Matches(parent.Repr()))
 }
 
 func (et *entityTreeImpl) GetContainerEntities() []Entity {

internal/page/entities.go

@@ -93,7 +93,7 @@ func (p EntityPage) HighjackingInput() bool {
 func (p EntityPage) ContentForFile() []string {
 	var content []string
 	for _, l := range p.getVisibleEntities() {
-		content = append(content, l.Render().Content())
+		content = append(content, l.Repr())
 	}
 	return content
 }