fix(analytics): string parameters in logEvent are sent as String instead of the parameter value (#76)

robingenz · web-flow · commit 2201fbd49dc7 · 2022-04-27T19:13:24.000+02:00
diff --git a/.changeset/hip-masks-mix.md b/.changeset/hip-masks-mix.md
@@ -0,0 +1,5 @@
+---
+"@capacitor-firebase/analytics": patch
+---
+
+fix(android): string parameters in `logEvent` are sent as `String` instead of the parameter value
diff --git a/packages/analytics/android/src/main/java/dev/robingenz/capacitorjs/plugins/firebase/analytics/FirebaseAnalyticsHelper.java b/packages/analytics/android/src/main/java/dev/robingenz/capacitorjs/plugins/firebase/analytics/FirebaseAnalyticsHelper.java
@@ -109,7 +109,7 @@ public static Bundle createBundleFromJson(@Nullable JSONObject json) {
                         }
                         break;
                     default:
-                        bundle.putString(key, value.getClass().getSimpleName());
+                        bundle.putString(key, (String) value);
                 }
             }
         } catch (JSONException exception) {

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public static Bundle createBundleFromJson(@Nullable JSONObject json) {`
`109`	`109`	`}`
`110`	`110`	`break;`
`111`	`111`	`default:`
`112`		`- bundle.putString(key, value.getClass().getSimpleName());`
	`112`	`+ bundle.putString(key, (String) value);`
`113`	`113`	`}`
`114`	`114`	`}`
`115`	`115`	`} catch (JSONException exception) {`