Skip to content

Doesn't work on macs with M1 chip #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yamiteru opened this issue Feb 24, 2021 · 6 comments
Open

Doesn't work on macs with M1 chip #8

yamiteru opened this issue Feb 24, 2021 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@yamiteru
Copy link

I have Macbook Air 2020 with M1 and this app simply doesn't work. It doesn't matter if I click on enable or use the provided keybinding.

@rkbhochalya rkbhochalya added the help wanted Extra attention is needed label Mar 22, 2021
@rkbhochalya rkbhochalya changed the title Doesn't work Doesn't work on macs with M1 chip Mar 22, 2021
@jvican
Copy link

jvican commented Nov 10, 2021

This is a bummer. Do we know what's not working with the latest M1 Mac computers?

@rkbhochalya
Copy link
Owner

Hmm, looks like the non-public C++ API we are using in the app to toggle grayscale mode doesn't work on mac computers with M1 chip. I do not have a computer with M1 to test it atm.

@jvican
Copy link

jvican commented Nov 12, 2021

I'm guessing this is the one? https://github.com/rkbhochalya/grayscale-mode/blob/master/GrayscaleMode/grayscale.h

Where did you find that private C++ API in the first place? Maybe we can go to the docs/code you looked at and see if they updated it to work with M1 chips.

@jvican
Copy link

jvican commented Dec 2, 2021

Can you provide the info above whenever you have some time @rkbhochalya?

@jvican
Copy link

jvican commented May 7, 2022

Looks like @brettferdosi has done an amazing job reverse engineering the proper way to toggle grayscale mode, and can be found here https://github.com/brettferdosi/grayscale/blob/master/Sources/Bridge.h

Just tested it by installing his app and it worked nicely. So we might want to port over his code into this app so that grayscale-mode can run on the Apple M1 chip family. Won't have the time to do this myself but writing it here in hope that someone else can pick it up.

@NightMachinery
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants