Skip to content

TM1638 library does not compile on ESP8266 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkrajendra opened this issue Jun 12, 2019 · 3 comments
Open

TM1638 library does not compile on ESP8266 #48

bkrajendra opened this issue Jun 12, 2019 · 3 comments

Comments

@bkrajendra
Copy link

bkrajendra commented Jun 12, 2019

TM1638 library does not compile on ESP8266. While same library all example runs perfectly on Arduino Nano.
pasz1972/HassMqqtAlarmPanelTM1638#7

@bkrajendra
Copy link
Author

bkrajendra commented Jun 27, 2019

Ive resolved this ESP8266 compatibility issue by making changes in TM16XX.cpp file.

Change: line no 44 from

sendCommand(0x80 | (activateDisplay ? 8 : 0) | min(7, intensity));

to

sendCommand(0x80 | (activateDisplay ? 8 : 0) | min(byte(7), intensity));

and also line no 56 from :

sendCommand(0x80 | (active ? 8 : 0) | min(7, intensity));

to

sendCommand(0x80 | (active ? 8 : 0) | min(byte(7), intensity));

i've created a pull request for this.
#49

@mager33
Copy link

mager33 commented Jan 20, 2020

Thank you!

@vasanth555
Copy link

Works nicely on ESP32 :) Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants