Skip to content

Optimize lru_cache get-and-put pattern in HashAgg #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #7289
TennyZhuang opened this issue Mar 21, 2023 · 2 comments · Fixed by #8691
Closed
Tracked by #7289

Optimize lru_cache get-and-put pattern in HashAgg #8687

TennyZhuang opened this issue Mar 21, 2023 · 2 comments · Fixed by #8691
Assignees
@stdrc
Labels
type/perf Type: Performance. type/refactor Type: Refactoring.
Milestone
release-0.19

Comments

@TennyZhuang
Copy link
Contributor

We should use get_mut here, although some unsafe codes are necessary.

The work was done in #7752, however it can't be merged now.

image
@TennyZhuang TennyZhuang added the type/feature Type: New feature. label Mar 21, 2023
@github-actions github-actions bot added this to the release-0.19 milestone Mar 21, 2023
@TennyZhuang TennyZhuang added type/refactor Type: Refactoring. type/perf Type: Performance. and removed type/feature Type: New feature. labels Mar 21, 2023
@lmatz lmatz mentioned this issue Mar 21, 2023
Open
54 tasks
@stdrc stdrc mentioned this issue Mar 21, 2023
Merged
7 tasks
@kwannoel
Copy link
Contributor

We should use get_mut here, although some unsafe codes are necessary.

The work was done in #7752, however it can't be merged now.

image

How does get_mut optimize lru_cache access?

@lmatz
Copy link
Contributor

lmatz commented Mar 22, 2023 •
edited
Loading

How does get_mut optimize lru_cache access?

otherwise, two extra copies and one extra O(1) operations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stdrc stdrc

Labels
type/perf Type: Performance. type/refactor Type: Refactoring.
Projects
None yet
Milestone
release-0.19
Development

Successfully merging a pull request may close this issue.

perf(hash agg): use get_mut instead of pop+put pattern risingwavelabs/risingwave
4 participants
@stdrc @lmatz @TennyZhuang @kwannoel