Skip to content

incorrect assertion check_split_assignment_is_migration #12065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zwang28 opened this issue Sep 4, 2023 · 0 comments · Fixed by #12117
Closed

incorrect assertion check_split_assignment_is_migration #12065

zwang28 opened this issue Sep 4, 2023 · 0 comments · Fixed by #12117
Assignees
@shanicky
Labels
type/bug Type: Bug. Only for issues.
Milestone
release-1.2

Comments

@zwang28
Copy link
Contributor

zwang28 commented Sep 4, 2023

Describe the bug

When a source receive a Mutation::SourceChangeSplit, which contains actor_splits for another source, it'll incorrectly fail check_split_assignment_is_migration. Because check_split_assignment_is_migration doesn't distinguish between sources, and thus split_to_actors_index may be called twice with the same split_id belonging to different sources, and fail the assertion.

Error message/log

No response

To Reproduce

No response

Expected behavior

No response

How did you deploy RisingWave?

No response

The version of RisingWave

No response

Additional context

No response
@zwang28 zwang28 added the type/bug Type: Bug. Only for issues. label Sep 4, 2023
@github-actions github-actions bot added this to the release-1.2 milestone Sep 4, 2023
@zwang28 zwang28 changed the title incorrect assertion incorrect assertion check_split_assignment_is_migration Sep 4, 2023
@shanicky shanicky linked a pull request Sep 10, 2023 that will close this issue
fix: temporarily remove the assert checking for split migration #12117
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanicky shanicky

Labels
type/bug Type: Bug. Only for issues.
Projects
None yet
Milestone
release-1.2
Development

Successfully merging a pull request may close this issue.

fix: temporarily remove the assert checking for split migration risingwavelabs/risingwave
2 participants
@shanicky @zwang28