Skip to content

Commit 7c7f9f9

Browse files
committed
make from_protobuf and to_protobuf private
Signed-off-by: Richard Chien <[email protected]>
1 parent 82e087f commit 7c7f9f9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/common/src/util/sort_util.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ pub enum Direction {
3838
}
3939

4040
impl Direction {
41-
pub fn from_protobuf(direction: &PbDirection) -> Self {
41+
fn from_protobuf(direction: &PbDirection) -> Self {
4242
match direction {
4343
PbDirection::Ascending => Self::Ascending,
4444
PbDirection::Descending => Self::Descending,
4545
PbDirection::Unspecified => unreachable!(),
4646
}
4747
}
4848

49-
pub fn to_protobuf(self) -> PbDirection {
49+
fn to_protobuf(self) -> PbDirection {
5050
match self {
5151
Self::Ascending => PbDirection::Ascending,
5252
Self::Descending => PbDirection::Descending,
@@ -74,15 +74,15 @@ enum NullsAre {
7474
}
7575

7676
impl NullsAre {
77-
pub fn from_protobuf(nulls_are: &PbNullsAre) -> Self {
77+
fn from_protobuf(nulls_are: &PbNullsAre) -> Self {
7878
match nulls_are {
7979
PbNullsAre::Largest => Self::Largest,
8080
PbNullsAre::Smallest => Self::Smallest,
8181
PbNullsAre::Unspecified => unreachable!(),
8282
}
8383
}
8484

85-
pub fn to_protobuf(self) -> PbNullsAre {
85+
fn to_protobuf(self) -> PbNullsAre {
8686
match self {
8787
Self::Largest => PbNullsAre::Largest,
8888
Self::Smallest => PbNullsAre::Smallest,

0 commit comments

Comments
 (0)