chore(types): move types and make mods private (#9554)

Signed-off-by: Runji Wang <[email protected]>

Author: wangrunji0408

src/batch/src/executor/insert.rs

@@ -19,8 +19,9 @@ use futures::future::try_join_all;
 use futures_async_stream::try_stream;
 use itertools::Itertools;
 use risingwave_common::array::column::Column;
-use risingwave_common::array::serial_array::SerialArray;
-use risingwave_common::array::{ArrayBuilder, DataChunk, Op, PrimitiveArrayBuilder, StreamChunk};
+use risingwave_common::array::{
+    ArrayBuilder, DataChunk, Op, PrimitiveArrayBuilder, SerialArray, StreamChunk,
+};
 use risingwave_common::catalog::{Field, Schema, TableId, TableVersionId};
 use risingwave_common::error::{Result, RwError};
 use risingwave_common::types::DataType;

src/common/benches/bench_encoding.rs

@@ -17,8 +17,9 @@ use std::sync::Arc;
 
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 use risingwave_common::array::{ListValue, StructValue};
-use risingwave_common::types::struct_type::StructType;
-use risingwave_common::types::{DataType, Date, Datum, Interval, ScalarImpl, Time, Timestamp};
+use risingwave_common::types::{
+    DataType, Date, Datum, Interval, ScalarImpl, StructType, Time, Timestamp,
+};
 use risingwave_common::util::sort_util::OrderType;
 use risingwave_common::util::{memcmp_encoding, value_encoding};
 

src/common/src/array/arrow.rs

@@ -22,8 +22,7 @@ use itertools::Itertools;
 
 use super::column::Column;
 use super::*;
-use crate::types::num256::Int256;
-use crate::types::struct_type::StructType;
+use crate::types::{Int256, StructType};
 use crate::util::iter_util::ZipEqFast;
 
 // Implement bi-directional `From` between `DataChunk` and `arrow_array::RecordBatch`.
@@ -124,7 +123,7 @@ impl From<&arrow_schema::DataType> for DataType {
             Binary => Self::Bytea,
             Utf8 => Self::Varchar,
             LargeUtf8 => Self::Jsonb,
-            Struct(field) => Self::Struct(Arc::new(struct_type::StructType {
+            Struct(field) => Self::Struct(Arc::new(StructType {
                 fields: field.iter().map(|f| f.data_type().into()).collect(),
                 field_names: field.iter().map(|f| f.name().clone()).collect(),
             })),
@@ -653,7 +652,7 @@ impl TryFrom<&arrow_array::StructArray> for StructArray {
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::types::interval::test_utils::IntervalTestExt;
+    use crate::types::test_utils::IntervalTestExt;
     use crate::{array, empty_array};
 
     #[test]

src/common/src/array/bool_array.rs

@@ -179,7 +179,7 @@ mod tests {
     use itertools::Itertools;
 
     use super::*;
-    use crate::array::{read_bool_array, NULL_VAL_FOR_HASH};
+    use crate::array::{ArrayImpl, NULL_VAL_FOR_HASH};
     use crate::util::iter_util::ZipEqFast;
 
     fn helper_test_builder(data: Vec<Option<bool>>) -> BoolArray {
@@ -228,7 +228,9 @@ mod tests {
             let array = helper_test_builder(v.clone());
 
             let encoded = array.to_protobuf();
-            let decoded = read_bool_array(&encoded, num_bits).unwrap().into_bool();
+            let decoded = ArrayImpl::from_protobuf(&encoded, num_bits)
+                .unwrap()
+                .into_bool();
 
             let equal = array
                 .iter()

src/common/src/array/column_proto_readers.rs

@@ -25,8 +25,7 @@ use crate::array::{
     PrimitiveArrayBuilder, PrimitiveArrayItemType, TimeArrayBuilder, TimestampArrayBuilder,
 };
 use crate::buffer::Bitmap;
-use crate::types::interval::Interval;
-use crate::types::{Date, Time, Timestamp};
+use crate::types::{Date, Interval, Time, Timestamp};
 
 // TODO: Use techniques like apache arrow flight RPC to eliminate deserialization.
 // https://arrow.apache.org/docs/format/Flight.html

src/common/src/array/data_chunk.rs

@@ -29,9 +29,7 @@ use crate::estimate_size::EstimateSize;
 use crate::field_generator::{FieldGeneratorImpl, VarcharProperty};
 use crate::hash::HashCode;
 use crate::row::Row;
-use crate::types::struct_type::StructType;
-use crate::types::to_text::ToText;
-use crate::types::{DataType, ToOwnedDatum};
+use crate::types::{DataType, StructType, ToOwnedDatum, ToText};
 use crate::util::hash_util::finalize_hashers;
 use crate::util::iter_util::{ZipEqDebug, ZipEqFast};
 use crate::util::value_encoding::{
@@ -42,6 +40,7 @@ use crate::util::value_encoding::{
 /// [`DataChunk`] is a collection of Columns,
 /// a with visibility mask for each row.
 /// For instance, we could have a [`DataChunk`] of this format.
+///
 /// | v1 | v2 | v3 |
 /// |----|----|----|
 /// | 1  | a  | t  |
@@ -52,6 +51,7 @@ use crate::util::value_encoding::{
 /// Our columns are v1, v2, v3.
 /// Then, if the Visibility Mask hides rows 2 and 4,
 /// We will only have these rows visible:
+///
 /// | v1 | v2 | v3 |
 /// |----|----|----|
 /// | 1  | a  | t  |

src/common/src/array/interval_array.rs

@@ -13,7 +13,7 @@
 // limitations under the License.
 
 use super::{PrimitiveArray, PrimitiveArrayBuilder};
-use crate::types::interval::Interval;
+use crate::types::Interval;
 
 pub type IntervalArray = PrimitiveArray<Interval>;
 pub type IntervalArrayBuilder = PrimitiveArrayBuilder<Interval>;
@@ -23,7 +23,7 @@ mod tests {
     use super::IntervalArray;
     use crate::array::interval_array::{Interval, IntervalArrayBuilder};
     use crate::array::{Array, ArrayBuilder};
-    use crate::types::interval::test_utils::IntervalTestExt;
+    use crate::types::test_utils::IntervalTestExt;
 
     #[test]
     fn test_interval_array() {