create local shellcheck hook that uses shellcheck from container (#523)

fixes #520

Co-authored-by: Derek Hower <[email protected]>

Author: kbroch-rivosinc

.devcontainer/Dockerfile

@@ -25,7 +25,8 @@ RUN apt-get install -y --no-install-recommends git \
                                                clang-format \
                                                clang-tidy \
                                                libelf-dev \
-                                               gcc-riscv64-unknown-elf
+                                               gcc-riscv64-unknown-elf \
+                                               shellcheck
 RUN apt-get clean autoclean
 RUN apt-get autoremove -y
 RUN rm -rf /var/lib/{apt,dpkg,cache,log}/*

.pre-commit-config.yaml

@@ -74,11 +74,14 @@ repos:
     hooks:
       - id: pyupgrade
 
-  # - repo: https://github.com/koalaman/shellcheck-precommit
-  #   rev: v0.10.0
-  #   hooks:
-  #     - id: shellcheck
-  #       args: ["--severity=error"]
+  - repo: local
+    hooks:
+      - id: shellcheck
+        name: shellcheck
+        types: [shell]
+        language: system
+        entry: shellcheck
+        args: ["--severity=error"]
 
   - repo: https://github.com/scop/pre-commit-shfmt
     rev: v3.11.0-1

bin/.container-tag

@@ -1 +1 @@
-0.5
+0.6

container.def

@@ -34,7 +34,8 @@ From: ubuntu:24.04
                                               libelf-dev \
                                               gcc-riscv64-linux-gnu \
                                               gcc-riscv64-unknown-elf \
-                                              libc6-dev-riscv64-cross
+                                              libc6-dev-riscv64-cross \
+                                              shellcheck
   # cleanup
   apt-get clean autoclean
   apt-get autoremove -y

lib/deploy.sh

@@ -1,8 +1,8 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # deploy artifacts to a directory, in preparation for GitHub deployment
 
-ROOT=$(dirname $(dirname $(realpath $BASH_SOURCE[0])))
+ROOT=$(dirname $(dirname $(realpath ${BASH_SOURCE[0]})))
 
 DEPLOY_DIR="$ROOT/_site"
 PAGES_URL="https://riscv-software-src.github.io/riscv-unified-db"