Merge pull request #367 from RomanBurunkov/master

Fix: Cannot read properties of undefined (reading 'includes').

Author: RomanBurunkov

lib/isEligibleRequest.js

@@ -37,4 +37,10 @@ const hasAcceptableContentType = (req) => {
  * @param {Object} req Express req object
  * @returns {Boolean}
  */
-module.exports = (req) => hasBody(req) && hasAcceptableMethod(req) && hasAcceptableContentType(req);
+module.exports = (req) => {
+  try {
+    return hasBody(req) && hasAcceptableMethod(req) && hasAcceptableContentType(req);
+  } catch (e) {
+    return false;
+  }
+};

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "express-fileupload",
-  "version": "1.4.2",
+  "version": "1.4.3",
   "author": "Richard Girges <[email protected]>",
   "description": "Simple express file upload middleware that wraps around Busboy",
   "main": "./lib/index",

package.json

@@ -113,4 +113,16 @@ describe('isEligibleRequest function tests', () => {
     const result = isEligibleRequest(req);
     assert.equal(result, false);
   });
+  it('should return false if the request is empty or not provided', () => {
+    const result = isEligibleRequest();
+    assert.equal(result, false);
+  });
+  it('should return false if content-type is not specified.', () => {
+    const req = {
+      method: 'POST',
+      headers: { 'content-length': '768751' }
+    };
+    const result = isEligibleRequest(req);
+    assert.equal(result, false);
+  });
 });