Skip to content

Commit 0ac6c2e

Browse files
fjtiradorgdoliveira
authored andcommitted
[Fix apache#3480] Changing jsonb to varchar (apache#3484)
* [Fix apache#3469 Fix apache#3480] Changing jsonb to varchar * [Fix apache#3480] Change blob to varbinary for ansi
1 parent 92c33c5 commit 0ac6c2e

File tree

7 files changed

+28
-29
lines changed

7 files changed

+28
-29
lines changed
Original file line numberDiff line numberDiff line change
@@ -34,17 +34,17 @@
3434
import com.fasterxml.jackson.databind.ObjectMapper;
3535
import com.fasterxml.jackson.databind.module.SimpleModule;
3636

37-
public class PostgreSQLCorrelationRepository {
37+
public class JDBCCorrelationRepository {
3838

39-
static final String INSERT = "INSERT INTO correlation_instances (id, encoded_correlation_id, correlated_id, correlation) VALUES (?, ?, ?, ?::json)";
39+
static final String INSERT = "INSERT INTO correlation_instances (id, encoded_correlation_id, correlated_id, correlation) VALUES (?, ?, ?, ?)";
4040
static final String DELETE = "DELETE FROM correlation_instances WHERE encoded_correlation_id = ?";
4141
private static final String FIND_BY_ENCODED_ID = "SELECT correlated_id, correlation FROM correlation_instances WHERE encoded_correlation_id = ?";
4242
private static final String FIND_BY_CORRELATED_ID = "SELECT encoded_correlation_id, correlation FROM correlation_instances WHERE correlated_id = ?";
4343

4444
private DataSource dataSource;
4545
private ObjectMapper objectMapper;
4646

47-
public PostgreSQLCorrelationRepository(DataSource dataSource) {
47+
public JDBCCorrelationRepository(DataSource dataSource) {
4848
this.dataSource = dataSource;
4949
this.objectMapper = ObjectMapperFactory.get().copy();
5050

Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@
2828
import org.kie.kogito.correlation.CorrelationService;
2929
import org.kie.kogito.event.correlation.MD5CorrelationEncoder;
3030

31-
public class PostgreSQLCorrelationService implements CorrelationService {
31+
public class JDBCCorrelationService implements CorrelationService {
3232

33-
private PostgreSQLCorrelationRepository repository;
33+
private JDBCCorrelationRepository repository;
3434
private CorrelationEncoder correlationEncoder;
3535

36-
public PostgreSQLCorrelationService(DataSource dataSource) {
37-
this.repository = new PostgreSQLCorrelationRepository(dataSource);
36+
public JDBCCorrelationService(DataSource dataSource) {
37+
this.repository = new JDBCCorrelationRepository(dataSource);
3838
this.correlationEncoder = new MD5CorrelationEncoder();
3939
}
4040

Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
CREATE TABLE process_instances
22
(
3-
id CHAR(36) NOT NULL,
4-
payload BLOB NOT NULL,
5-
process_id VARCHAR(4000) NOT NULL,
6-
version BIGINT(19),
7-
process_version VARCHAR(4000),
3+
id character(36) NOT NULL,
4+
payload varbinary(1000000) NOT NULL,
5+
process_id character varying(4000) NOT NULL,
6+
version bigint,
7+
process_version character varying(4000),
88
CONSTRAINT process_instances_pkey PRIMARY KEY (id)
99
);
1010
CREATE INDEX idx_process_instances_process_id ON process_instances (process_id, id, process_version);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
CREATE TABLE correlation_instances
2+
(
3+
id character(36) NOT NULL,
4+
encoded_correlation_id character varying(36) NOT NULL UNIQUE,
5+
correlated_id character varying(36) NOT NULL,
6+
correlation character varying(8000) NOT NULL,
7+
version bigint,
8+
CONSTRAINT correlation_instances_pkey PRIMARY KEY (id)
9+
);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
ALTER TABLE correlation_instances
2+
ALTER COLUMN correlation TYPE character varying;

addons/common/persistence/jdbc/src/test/java/org/kie/persistence/jdbc/correlation/JDBCCorrelationServiceIT.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.kie.kogito.correlation.CompositeCorrelation;
2828
import org.kie.kogito.correlation.CorrelationInstance;
2929
import org.kie.kogito.correlation.SimpleCorrelation;
30-
import org.kie.kogito.persistence.jdbc.correlation.PostgreSQLCorrelationService;
30+
import org.kie.kogito.persistence.jdbc.correlation.JDBCCorrelationService;
3131
import org.kie.kogito.testcontainers.KogitoPostgreSqlContainer;
3232
import org.postgresql.ds.PGSimpleDataSource;
3333
import org.testcontainers.containers.JdbcDatabaseContainer;
@@ -42,15 +42,15 @@ public class JDBCCorrelationServiceIT {
4242
@Container
4343
private static final KogitoPostgreSqlContainer PG_CONTAINER = new KogitoPostgreSqlContainer();
4444
private static PGSimpleDataSource dataSource;
45-
private static PostgreSQLCorrelationService correlationService;
45+
private static JDBCCorrelationService correlationService;
4646

4747
@BeforeAll
4848
public static void setUp() {
4949
dataSource = new PGSimpleDataSource();
5050
dataSource.setUrl(PG_CONTAINER.getJdbcUrl());
5151
dataSource.setUser(PG_CONTAINER.getUsername());
5252
dataSource.setPassword(PG_CONTAINER.getPassword());
53-
correlationService = new PostgreSQLCorrelationService(dataSource);
53+
correlationService = new JDBCCorrelationService(dataSource);
5454
//create table
5555
// DDLRunner.init(new GenericRepository(dataSource), true);
5656
initMigration(PG_CONTAINER, "postgresql");

quarkus/addons/persistence/jdbc/runtime/src/main/java/org/kie/kogito/persistence/quarkus/JDBCorrelationServiceProducer.java

+2-14
Original file line numberDiff line numberDiff line change
@@ -18,29 +18,17 @@
1818
*/
1919
package org.kie.kogito.persistence.quarkus;
2020

21-
import java.util.Optional;
22-
2321
import javax.sql.DataSource;
2422

25-
import org.eclipse.microprofile.config.inject.ConfigProperty;
2623
import org.kie.kogito.correlation.CorrelationService;
27-
import org.kie.kogito.event.correlation.DefaultCorrelationService;
28-
import org.kie.kogito.persistence.jdbc.correlation.PostgreSQLCorrelationService;
24+
import org.kie.kogito.persistence.jdbc.correlation.JDBCCorrelationService;
2925

3026
import jakarta.enterprise.inject.Produces;
31-
import jakarta.inject.Inject;
32-
33-
import static org.kie.kogito.persistence.quarkus.KogitoAddOnPersistenceJDBCConfigSourceFactory.DATASOURCE_DB_KIND;
34-
import static org.kie.kogito.persistence.quarkus.KogitoAddOnPersistenceJDBCConfigSourceFactory.POSTGRESQL;
3527

3628
public class JDBCorrelationServiceProducer {
3729

38-
@Inject
39-
@ConfigProperty(name = DATASOURCE_DB_KIND)
40-
Optional<String> dbKind;
41-
4230
@Produces
4331
public CorrelationService jdbcCorrelationService(DataSource dataSource) {
44-
return dbKind.filter(POSTGRESQL::equals).isPresent() ? new PostgreSQLCorrelationService(dataSource) : new DefaultCorrelationService();
32+
return new JDBCCorrelationService(dataSource);
4533
}
4634
}

0 commit comments

Comments
 (0)