-
-
Notifications
You must be signed in to change notification settings - Fork 196
UI Styles: Hover Styles #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Akin909 thanks for writing down your thoughts on how to implement the hover style api 💯. I think it'll be a great help in tackling the issue. Another idea I had was since we've got access to the actual nodes, could we maybe implement this on the node layer? |
@samatar26 if its possible we have some other styles like overflow which were dealt with there but I personally worry that layer gets very complex with all this adhoc logic especially if it isn't necessary to deal with it at that layer, I'd be curious what you think @bryphe? (should manipulating the style lists live at this layer, my inclination is not but then again it is the only common point for |
Has anyone started this yet? I was fiddling around with some UI and noticed that there are some UI-elements that could benefit from another look! e.g. something similar as your proposal might be a good idea for |
@lessp pretty sure no one is looking at this atm 👍 it'd be awesome to have functionality like this 💯 |
with @samatar26's change in #313, I think we can actually implement hover styles 🤔. I was thinking we could copy
bs-css
api which looks likeunder the hood that gets converted to a string. In our case was thinking
we could have the style added to
allProps
inStyle.re
asin the primitive(?) you could add and remove the hover list i.e. on mouseOver
and on mouse out remove the hover from the list that's passed down
one concern would be that you hijack the user's mouseOver and mouseOut so I suggest wrapping the handler
These are just an idea of how there's probably quite a few bits I haven't consider but hopefully this helps anyone curious about tackling it.
The text was updated successfully, but these errors were encountered: