Skip to content

Tagged components milestone 2: no more indicators #8129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teh-cmc opened this issue Nov 13, 2024 · 1 comment
Open

Tagged components milestone 2: no more indicators #8129

teh-cmc opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
🔩 data model Sorbet enhancement New feature or request ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Nov 13, 2024

The second milestone for tagged components is to remove the concept of indicator components entirely.
The semantics of the viewer must not be impacted in any way by that change.

  • Remove all codegen related to indicator components.
  • Replace all logic that relies on querying for indicators with new descriptor-based logic ("is there anything on that path that belongs to the Points3D archetype?").

@teh-cmc teh-cmc added enhancement New feature or request ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself 🔩 data model Sorbet labels Nov 13, 2024
@teh-cmc teh-cmc self-assigned this Dec 3, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Dec 5, 2024

Talked with @nikolausWest about the upgrade path and backwards compat.

We will need to:

  • Slap a deprecated flag on all indicator types, but keep them around for the SDKs.
  • Make sure that indicator types set the archetype_name in their descriptors, so the backend can find them by tag, without being aware of indicators at all.
  • Make the backend entirely tag-driven.

That way that kind of user code still works:

rr.log("points", rr.ColorBatch(colors), rr.Points3D.indicator())

and because indicator types are deprecated, the user gets a warning along these lines:

WARN: Indicator components are deprecated, use `rr.log("points", rr.ColorBatch(colors).with_descriptor(archetype_name="Points3D"))` instead

In the future, the SDK APIs will need to be much better to accommodate for custom tags and all, but that's another topic...

@Wumpf Wumpf assigned Wumpf and unassigned teh-cmc Apr 28, 2025
@Wumpf Wumpf mentioned this issue May 14, 2025
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔩 data model Sorbet enhancement New feature or request ⛃ re_datastore affects the datastore itself 🔍 re_query affects re_query itself
Projects
None yet
Development

No branches or pull requests

2 participants