-
Notifications
You must be signed in to change notification settings - Fork 451
Optimize mp4 parse times, and avoid duplicating their RAM use #7481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Does arrow bottom out in https://crates.io/crates/bytes ? That would be useful for storing RC-counted references across crates. Otherwise we have to consider a few different alternatives:
|
I think the best path forward is to change It should be less than a days worth of work. |
The vast majority of the time used by |
Even after #7860 we still copy video data for each sample. But |
Follow-up: #7878 |
Right now we effectively hold an mp4 blob at least twice: Raw in the (arrow) store and then again upon parsing in our mp4 object.
All larger pieces should just be pointers back to the raw blob in order to conserve memory.
Also general cleanup of mp4 crate is in order, this is a good opportunity.
This won't fly for streaming mp4 easily, but for full mp4 it should be doable to do indices into the blob.
The text was updated successfully, but these errors were encountered: