Skip to content

Commit f201277

Browse files
committed
backporting misc fixes
1 parent 0940492 commit f201277

File tree

5 files changed

+28
-15
lines changed

5 files changed

+28
-15
lines changed

crates/store/re_types_core/src/archetype.rs

+1-6
Original file line numberDiff line numberDiff line change
@@ -247,12 +247,7 @@ impl<A: Archetype> crate::ComponentBatch for GenericIndicatorComponent<A> {
247247
fn descriptor(&self) -> Cow<'_, ComponentDescriptor> {
248248
let component_name =
249249
format!("{}Indicator", A::name().full_name()).replace("archetypes", "components");
250-
ComponentDescriptor {
251-
archetype_name: Some(A::name()),
252-
archetype_field_name: None,
253-
component_name: component_name.into(),
254-
}
255-
.into()
250+
ComponentDescriptor::new(component_name).into()
256251
}
257252
}
258253

docs/snippets/all/descriptors/descr_builtin_archetype.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use rerun::{ChunkStore, ChunkStoreConfig, ComponentDescriptor, VersionPolicy};
22

33
#[allow(clippy::unwrap_used)]
44
fn main() -> Result<(), Box<dyn std::error::Error>> {
5-
const APP_ID: &str = "rerun_example_descriptors_builtin_archetype_vanilla";
5+
const APP_ID: &str = "rerun_example_descriptors_builtin_archetype";
66

77
let rec = rerun::RecordingStreamBuilder::new(APP_ID).spawn()?;
88

@@ -42,7 +42,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
4242

4343
let expected = vec![
4444
ComponentDescriptor {
45-
archetype_name: Some("rerun.archetypes.Points3D".into()),
45+
archetype_name: None,
4646
archetype_field_name: None,
4747
component_name: "rerun.components.Points3DIndicator".into(),
4848
},

docs/snippets/all/descriptors/descr_builtin_component.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use rerun::{ChunkStore, ChunkStoreConfig, Component as _, ComponentDescriptor, V
22

33
#[allow(clippy::unwrap_used)]
44
fn main() -> Result<(), Box<dyn std::error::Error>> {
5-
const APP_ID: &str = "rerun_example_descriptors_builtin_component_vanilla";
5+
const APP_ID: &str = "rerun_example_descriptors_builtin_component";
66

77
let rec = rerun::RecordingStreamBuilder::new(APP_ID).spawn()?;
88

docs/snippets/all/descriptors/descr_custom_archetype.rs

+16-4
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ impl rerun::AsComponents for CustomPoints3D {
8282

8383
#[allow(clippy::unwrap_used)]
8484
fn main() -> Result<(), Box<dyn std::error::Error>> {
85-
const APP_ID: &str = "rerun_example_descriptors_custom_component_vanilla";
85+
const APP_ID: &str = "rerun_example_descriptors_custom_archetype";
8686

8787
let rec = rerun::RecordingStreamBuilder::new(APP_ID).spawn()?;
8888

@@ -126,9 +126,21 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
126126
descriptors.sort();
127127

128128
let expected = vec![
129-
rerun::ComponentBatch::descriptor(&CustomPoints3D::indicator()).into_owned(),
130-
CustomPoints3D::overridden_color_descriptor(),
131-
CustomPoints3D::overridden_position_descriptor(),
129+
ComponentDescriptor {
130+
archetype_name: None,
131+
archetype_field_name: None,
132+
component_name: "user.CustomPoints3DIndicator".into(),
133+
},
134+
ComponentDescriptor {
135+
archetype_name: Some("user.CustomArchetype".into()),
136+
archetype_field_name: Some("colors".into()),
137+
component_name: rerun::components::Color::name(),
138+
},
139+
ComponentDescriptor {
140+
archetype_name: Some("user.CustomArchetype".into()),
141+
archetype_field_name: Some("positions".into()),
142+
component_name: "user.CustomPosition3D".into(),
143+
},
132144
];
133145

134146
similar_asserts::assert_eq!(expected, descriptors);

docs/snippets/all/descriptors/descr_custom_component.rs

+8-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ impl Component for CustomPosition3D {
4545

4646
#[allow(clippy::unwrap_used)]
4747
fn main() -> Result<(), Box<dyn std::error::Error>> {
48-
const APP_ID: &str = "rerun_example_descriptors_custom_component_vanilla";
48+
const APP_ID: &str = "rerun_example_descriptors_custom_component";
4949

5050
let rec = rerun::RecordingStreamBuilder::new(APP_ID).spawn()?;
5151

@@ -81,7 +81,13 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
8181
.collect::<Vec<_>>();
8282
descriptors.sort();
8383

84-
let expected = vec![CustomPosition3D::descriptor()];
84+
let expected = vec![
85+
ComponentDescriptor {
86+
archetype_name: Some("user.CustomArchetype".into()),
87+
archetype_field_name: Some("user.CustomArchetypeField".into()),
88+
component_name: "user.CustomPosition3D".into(),
89+
}, //
90+
];
8591

8692
similar_asserts::assert_eq!(expected, descriptors);
8793
}

0 commit comments

Comments
 (0)