Automatically add unknown catalog servers (#9482)

previously, when clicking a rerun dataplatform url to a catalog you're
not connected with, the recording would load fine but not show up on the
left hand panel since that depended on the catalog being known.

Alternatives considered:
Show the recording under "disconnected". In some ways this is nicer
since nobody asked to connect to the catalog as a whole. But as long as
this is light weight in both perf and ux this is probably fine 🤷

Author: Wumpf

crates/viewer/re_redap_browser/src/servers.rs

@@ -144,6 +144,11 @@ impl RedapServers {
         self.servers.is_empty() && self.pending_servers.is_empty()
     }
 
+    /// Whether we already know about a given server (or have it queued to be added).
+    pub fn has_server(&self, origin: &re_uri::Origin) -> bool {
+        self.servers.contains_key(origin) || self.pending_servers.contains(origin)
+    }
+
     /// Add a server to the hub.
     pub fn add_server(&self, origin: re_uri::Origin) {
         let _ = self.command_sender.send(Command::AddServer(origin));

crates/viewer/re_viewer/src/app_state.rs

@@ -688,7 +688,7 @@ impl AppState {
         }
 
         // This must run after any ui code, or other code that tells egui to open an url:
-        check_for_clicked_hyperlinks(&ctx);
+        check_for_clicked_hyperlinks(&ctx, redap_servers);
 
         // Deselect on ESC. Must happen after all other UI code to let them capture ESC if needed.
         if ui.input(|i| i.key_pressed(egui::Key::Escape)) && !is_any_popup_open {
@@ -875,7 +875,7 @@ pub(crate) fn recording_config_entry<'cfgs>(
 /// Must run after any ui code, or other code that tells egui to open an url.
 ///
 /// See [`re_ui::UiExt::re_hyperlink`] for displaying hyperlinks in the UI.
-fn check_for_clicked_hyperlinks(ctx: &ViewerContext<'_>) {
+fn check_for_clicked_hyperlinks(ctx: &ViewerContext<'_>, redap_servers: &RedapServers) {
     let recording_scheme = "recording://";
 
     let mut recording_path = None;
@@ -884,9 +884,9 @@ fn check_for_clicked_hyperlinks(ctx: &ViewerContext<'_>) {
     ctx.egui_ctx().output_mut(|o| {
         o.commands.retain_mut(|command| {
             if let egui::OutputCommand::OpenUrl(open_url) = command {
-                let is_rerun_url = open_url.url.parse::<re_uri::RedapUri>().is_ok();
+                let redap_uri = open_url.url.parse::<re_uri::RedapUri>();
 
-                if is_rerun_url {
+                if let Ok(redap_uri) = redap_uri {
                     let data_source = re_data_source::DataSource::from_uri(
                         re_log_types::FileSource::Uri,
                         open_url.url.clone(),
@@ -909,6 +909,18 @@ fn check_for_clicked_hyperlinks(ctx: &ViewerContext<'_>) {
                         }),
                     });
 
+                    // If this is a dataset url, we add the server if we don't know about it already.
+                    // Otherwise we end up in a situation where we have a data from an unknown server,
+                    // which is unnecessary and can get us into a strange ui state.
+                    if let re_uri::RedapUri::DatasetData(dataset_endpoint) = redap_uri {
+                        if !redap_servers.has_server(&dataset_endpoint.origin) {
+                            ctx.command_sender()
+                                .send_system(SystemCommand::AddRedapServer {
+                                    endpoint: re_uri::CatalogEndpoint::new(dataset_endpoint.origin),
+                                });
+                        }
+                    }
+
                     match data_source.stream(on_cmd, None) {
                         Ok(re_data_source::StreamSource::LogMessages(rx)) => {
                             ctx.command_sender()