Skip to content

Commit 91a2066

Browse files
committed
fix rust issues, remove list of visualizer overrides
1 parent 3b5a3d7 commit 91a2066

File tree

9 files changed

+10
-78
lines changed

9 files changed

+10
-78
lines changed

crates/build/re_types_builder/src/docs.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ mod doclink_translation {
464464

465465
fn test_objects() -> Objects {
466466
Objects {
467-
objects: [(
467+
objects: std::iter::once((
468468
"rerun.views.Spatial2DView".to_owned(),
469469
Object {
470470
virtpath: "path".to_owned(),
@@ -479,8 +479,7 @@ mod doclink_translation {
479479
class: crate::ObjectClass::Struct,
480480
datatype: None,
481481
},
482-
)]
483-
.into_iter()
482+
))
484483
.collect(),
485484
}
486485
}

crates/build/re_types_builder/src/report.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ impl Report {
103103

104104
/// This outputs all errors and warnings to stderr and panics if there were any errors.
105105
pub fn finalize(&self) {
106-
use colored::*;
106+
use colored::Colorize;
107107

108108
let mut errored = false;
109109

crates/store/re_types/definitions/rerun/blueprint/components/map_provider.fbs

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ enum MapProvider: ubyte (
88
/// Invalid value. Won't show up in generated types.
99
Invalid = 0,
1010

11-
/// OpenStreetMap is the default map provider.
11+
/// `OpenStreetMap` is the default map provider.
1212
OpenStreetMap (default),
1313

1414
/// Mapbox Streets is a minimalistic map designed by Mapbox.

crates/store/re_types/definitions/rerun/blueprint/components/visualizer_overrides.fbs

+2-23
Original file line numberDiff line numberDiff line change
@@ -21,28 +21,7 @@ table VisualizerOverrides (
2121
"attr.rust.override_crate": "re_types_blueprint"
2222
) {
2323
/// Names of the visualizers that should be active.
24-
///
25-
/// The built-in visualizers are:
26-
/// - 'BarChart'
27-
/// - 'Arrows2D'
28-
/// - 'Arrows3D'
29-
/// - 'Asset3D'
30-
/// - 'Boxes2D'
31-
/// - 'Boxes3D'
32-
/// - 'Cameras'
33-
/// - 'DepthImage'
34-
/// - 'Image'
35-
/// - 'Lines2D'
36-
/// - 'Lines3D'
37-
/// - 'Mesh3D'
38-
/// - 'Points2D'
39-
/// - 'Points3D'
40-
/// - 'Transform3DArrows'
41-
/// - 'Tensor'
42-
/// - 'TextDocument'
43-
/// - 'TextLog'
44-
/// - 'SegmentationImage'
45-
/// - 'SeriesLine'
46-
/// - 'SeriesPoint'
24+
// TODO(andreas): We used to list the built-in visualizers here, but it outdates too quickly.
25+
// We either need to manifest the concept of visualizers in the sdk facing type system or rethink how this is done.
4726
visualizers: rerun.blueprint.datatypes.Utf8List (order: 100);
4827
}

crates/store/re_types/src/blueprint/components/map_provider.rs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/store/re_types_blueprint/src/blueprint/components/visualizer_overrides.rs

-23
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_cpp/src/rerun/blueprint/components/map_provider.hpp

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_cpp/src/rerun/blueprint/components/visualizer_overrides.hpp

-23
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

rerun_py/rerun_sdk/rerun/blueprint/components/map_provider.py

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)