Skip to content

Commit 60df8f9

Browse files
committed
todos
1 parent 7956a10 commit 60df8f9

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

crates/re_data_source/src/data_loader/loader_directory.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1-
// TODO: issue -> HIVE partitiong, timestamp regexes, zip files, that kinda thing
2-
31
/// Loads entire directories, using the appropriate [`crate::DataLoader`]:s for each files within.
2+
//
3+
// TODO(cmc): There are a lot more things than can be done be done when it comes to the semantics
4+
// of a folder, e.g.: HIVE-like partitioning, similarly named files with different indices and/or
5+
// timestamps (e.g. a folder of video frames), etc.
6+
// We could support some of those at some point, or at least add examples to show users how.
47
pub struct DirectoryLoader;
58

69
impl crate::DataLoader for DirectoryLoader {
@@ -69,7 +72,7 @@ impl crate::DataLoader for DirectoryLoader {
6972
_contents: std::borrow::Cow<'_, [u8]>,
7073
_tx: std::sync::mpsc::Sender<crate::LoadedData>,
7174
) -> Result<(), crate::DataLoaderError> {
72-
// TODO: zip file supports
75+
// TODO(cmc): This could make sense to implement for e.g. archive formats (zip, tar, …)
7376
Ok(()) // simply not interested
7477
}
7578
}

0 commit comments

Comments
 (0)