Skip to content

Commit 558ff44

Browse files
authored
Fix some of nightly error (#7912)
### What Fix some error in CI: - don't install pixi twice - do as the link checker says (sometime) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7912?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7912?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7912) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
1 parent 2383754 commit 558ff44

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/workflows/reusable_bench.yml

+5-6
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,11 @@ jobs:
7878
- uses: prefix-dev/[email protected]
7979
with:
8080
pixi-version: v0.34.0
81-
# Only has the deps for round-trips. Not all examples.
82-
environments: wheel-test-min
81+
# default: for the rendering step
82+
# wheel-test-min: minimal env for roundtrips (less heavy than wheel-test/examples)
83+
environments: >-
84+
default
85+
wheel-test-min
8386
8487
- name: Download test assets
8588
run: pixi run -e wheel-test-min python ./tests/assets/download_test_assets.py
@@ -167,10 +170,6 @@ jobs:
167170
save-data-file: false
168171
auto-push: false
169172

170-
- uses: prefix-dev/[email protected]
171-
with:
172-
pixi-version: v0.34.0
173-
174173
- name: Render benchmark result
175174
if: github.ref == 'refs/heads/main'
176175
run: |

crates/viewer/re_renderer/src/resource_managers/yuv_converter.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ pub enum YuvMatrixCoefficients {
202202
/// These are the same primaries we usually assume and use for all our rendering
203203
/// since they are the same primaries used by sRGB.
204204
/// <https://en.wikipedia.org/wiki/Rec._709#Relationship_to_sRGB/>
205-
/// The OETF/EOTF function (<https://en.wikipedia.org/wiki/Transfer_functions_in_imaging/>) is different,
205+
/// The OETF/EOTF function (<https://en.wikipedia.org/wiki/Transfer_functions_in_imaging>) is different,
206206
/// but for all other purposes they are the same.
207207
/// (The only reason for us to convert to optical units ("linear" instead of "gamma") is for
208208
/// lighting & tonemapping where we typically start out with an sRGB image!)

0 commit comments

Comments
 (0)