Skip to content

Commit 2c5135d

Browse files
committed
don't require ninja on roundtrip tests
1 parent 2653399 commit 2c5135d

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

docs/code-examples/roundtrips.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -121,11 +121,10 @@ def main() -> None:
121121
build_type = "Debug"
122122
if args.release:
123123
build_type = "Release"
124+
# TODO(andreas): We should pixi for the prepare so we can ensure we have build tooling ready
124125
configure_args = [
125126
"cmake",
126127
"-G",
127-
"Ninja",
128-
"-B",
129128
cpp_build_dir,
130129
f"-DCMAKE_BUILD_TYPE={build_type}",
131130
"-DCMAKE_COMPILE_WARNING_AS_ERROR=ON",

tests/roundtrips.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,9 @@ def main() -> None:
8686
build_type = "Debug"
8787
if args.release:
8888
build_type = "Release"
89+
# TODO(andreas): We should pixi for the prepare so we can ensure we have build tooling ready
8990
configure_args = [
9091
"cmake",
91-
"-G",
92-
"Ninja",
9392
"-B",
9493
cpp_build_dir,
9594
f"-DCMAKE_BUILD_TYPE={build_type}",

0 commit comments

Comments
 (0)