Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use baseBranch prefix whenever there's patterns #34937

Open
rarkins opened this issue Mar 21, 2025 · 0 comments
Open

Use baseBranch prefix whenever there's patterns #34937

rarkins opened this issue Mar 21, 2025 · 0 comments
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others

Comments

@rarkins
Copy link
Collaborator

rarkins commented Mar 21, 2025

Describe the proposed change(s).

Discussed in #34570

Quoting:

Consider the following config:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "dependencyDashboard": true,
  "baseBranches": [
    "$default",
    // Literal string
    "does-not-exist-yet",
  ],
}

The update branch name contains the default branch name after the branchPrefix, regardless of wether the other base branch exists. The dependency dashboard contains a warning (not mentioning the name) for the missing branch.

Compare this against:

{
  "dependencyDashboard": true,
  "baseBranches": [
    "$default",
    // Regular expression
    "/does-not-exist-yet/",
  ],
}

The dependency dashboard does not report an error, and the branch names for updates to the default branch does not contain the default branch. That is, until the creation of the "does-not-exist-yet" branch. Once it exists, all outstanding branches/PRs for the default branch will be deleted/autoclosed, and new branches (as configured) will be created with an infix of the branch name after the branchPrefix.

Change: we should add additionalBranchPrefix for all branches even if the pattern does not match anything.

@rarkins rarkins added the priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others
Projects
None yet
Development

No branches or pull requests

1 participant