Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-actions): add some community action support #34791

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Mar 13, 2025

Changes

add support for github actions

  • astral-sh/setup-uv
  • jaxxstorm/action-install-gh-release
  • pnpm/action-setup
  • prefix-dev/setup-pixi

Context

close #34767

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

rarkins
rarkins previously approved these changes Mar 13, 2025
@trim21 trim21 marked this pull request as draft March 13, 2025 21:45
@trim21 trim21 marked this pull request as ready for review March 21, 2025 11:08
@trim21 trim21 requested a review from viceice March 21, 2025 11:10
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicted

@trim21 trim21 requested a review from viceice April 1, 2025 14:39
Comment on lines +28 to +30
matchFullUrl('github.com', action),
matchFullUrl('code.forgejo.org', action),
matchFullUrl('data.forgejo.org', action),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should somehow allow users to configure addional hosts 🤔

Copy link
Contributor Author

@trim21 trim21 Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you want to match pnpm/setup-pnpm and https://*/pnpm/setup-pnpm ? not sure I understand what you mean.

@trim21

This comment was marked as outdated.

@trim21 trim21 requested a review from viceice April 3, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for pnpm/action-setup with version: updates
3 participants