Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): managerFilePatterns #34615

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat(config): managerFilePatterns #34615

wants to merge 19 commits into from
+625 −505

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Mar 4, 2025 •
edited
Loading

Changes

  • Migrate fileMatch to filePatterns
  • Add glob pattern support

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository
  1. https://github.com/Rahul-renovate-testing/renovate/pulls (test run on renovate repo)
  2. https://github.com/Rahul-renovate-testing/managerFilePatterns (migration testing & tested working of managerFilePatterns)

secustor
secustor reviewed Mar 4, 2025
View reviewed changes
@RahulGautamSingh @secustor
Apply suggestions from code review
db189af 
Co-authored-by: Sebastian Poxhofer <[email protected]>
HonkingGoose
HonkingGoose suggested changes Mar 5, 2025
View reviewed changes
@viceice viceice mentioned this pull request Mar 5, 2025
Open
6 tasks
viceice
viceice reviewed Mar 5, 2025
View reviewed changes
secustor
secustor previously approved these changes Mar 5, 2025
View reviewed changes
@RahulGautamSingh RahulGautamSingh requested a review from viceice March 5, 2025 20:54
viceice
viceice reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some more samples, which can be simplified by using glob, otherwise LGTM

viceice
viceice reviewed Mar 6, 2025
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do the regex to glob changes in a followup pr of cause

@viceice
Copy link
Member

viceice commented Mar 6, 2025

needs update because of:

rarkins
rarkins requested changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review done. Please note each of the suggested changes and apply them widely to the whole PR. e.g. ^foo$ patterns should always just be foo.

secustor
secustor reviewed Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict and a lot of conversations should not be solved.

@RahulGautamSingh
Copy link
Collaborator Author

Conflict and a lot of conversations should not be solved.

Reverted he changes as per this comment. Will replace regex with glob in future Prs

secustor
secustor previously approved these changes Mar 16, 2025
View reviewed changes
rarkins
rarkins requested changes Mar 17, 2025
View reviewed changes
@RahulGautamSingh RahulGautamSingh changed the title feat(config): filePatterns feat(config): managerFilePatterns Mar 26, 2025
secustor
secustor previously approved these changes Mar 27, 2025
View reviewed changes
rarkins
rarkins requested changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until second week of April

viceice
viceice previously approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume we agreed to simplify regex patterns in a follow up pr 🙃

@rarkins rarkins dismissed stale reviews from viceice and secustor via f97c89d April 8, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rarkins rarkins rarkins approved these changes

@viceice viceice viceice left review comments

@secustor secustor secustor left review comments

@trim21 trim21 Awaiting requested review from trim21

@HonkingGoose HonkingGoose Awaiting requested review from HonkingGoose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate fileMatch to filePatterns and support matchRegexOrGlobList
6 participants
@RahulGautamSingh @viceice @rarkins @trim21 @secustor @HonkingGoose