Skip to content

fix(manager/github-actions): preserve full depName #33450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented Jan 7, 2025

Changes

Preserve the full dep name, so we can support replacements.
It's only relevant for Gitea / Forgejo. Github doesn't support those urls anyways.

It causes some open PR to be closed because of branch name changes, see sample repo below.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor January 7, 2025 15:12
@viceice viceice added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit ac9ddf3 Jan 7, 2025
39 checks passed
@viceice viceice deleted the fix/github-actions branch January 7, 2025 15:25
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.92.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants