Skip to content

feat(bazel-module): Support git_repository #33415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

reutermj
Copy link
Contributor

@reutermj reutermj commented Jan 5, 2025

Changes

This adds support for git_repository dependencies declared in MODULE.bazel files.

Context

The legacy WORKSPACE bazel manager supports git_repository dependencies, but the bazel-module manger does not. The WORKSPACE system is officially deprecated and bzlmod is the on-by-default dependency management system for bazel. MODULE.bazel files allow for git_repository dependencies to be declared, but renovate is not updating them.

This implementation departs from the legacy WORKSPACE implementation of git_repository by preferring the use of commit over tag. Use of tag is considered a not recommended practice in bazel because it can lead to non-reproducible builds, and the bazel will emit a warning suggesting the conversion of a tag to a commit. This implementation instead follows the implementation of git_override and uses commit.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins enabled auto-merge January 8, 2025 12:29
@rarkins rarkins added this pull request to the merge queue Jan 8, 2025
Merged via the queue into renovatebot:main with commit f97189c Jan 8, 2025
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.95.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

reutermj added a commit to cortecs-lang/cortecs that referenced this pull request Jan 8, 2025
renovate has been updated to handle git_repository dependencies. Strip out the hacky method for updating them

see: renovatebot/renovate#33415
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants