Skip to content

Commit 374a96f

Browse files
authored
chore: add jdk 24 to test matrixes (GoogleCloudPlatform#3796)
* chore: add jdk 24 to test matrixes this is in order to support graalvm upgrade * need to update source to use release: enables cross-compilation cleanly by instructing the compiler to use Java 17’s standard module definitions, solving the missing "system modules" problem. * disable * disable * disable * disable * disable * disable * disable
1 parent 0000f50 commit 374a96f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/unitTests.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
strategy:
2222
fail-fast: false
2323
matrix:
24-
java: [17, 19, 21]
24+
java: [17, 19, 21, 24]
2525
steps:
2626
- name: Get current date
2727
id: date

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
<checkstyle-rules.version>9.3</checkstyle-rules.version>
5757
<asciidoctor-maven-plugin.version>2.0.0</asciidoctor-maven-plugin.version>
5858
<native-maven-plugin.version>0.10.5</native-maven-plugin.version>
59-
<errorprone.version>2.34.0</errorprone.version>
59+
<errorprone.version>2.38.0</errorprone.version>
6060

6161
<!-- All checks except for javadoc enforced by default -->
6262
<skip.failsafe.tests>${skipTests}</skip.failsafe.tests>
@@ -659,11 +659,11 @@
659659
<artifactId>maven-compiler-plugin</artifactId>
660660
<version>${maven-compiler-plugin.version}</version>
661661
<configuration>
662-
<source>${maven.compiler.source}</source>
663-
<target>${maven.compiler.target}</target>
662+
<release>${maven.compiler.source}</release>
664663
<encoding>UTF-8</encoding>
665664
<fork>true</fork>
666665
<compilerArgs>
666+
<arg>--should-stop=ifError=FLOW</arg>
667667
<arg>-XDcompilePolicy=simple</arg>
668668
<arg>-Xplugin:ErrorProne -Xep:UnicodeInCode:OFF</arg>
669669
<!-- See: https://github.com/GoogleCloudPlatform/spring-cloud-gcp/pull/92 -->

0 commit comments

Comments
 (0)