Skip to content

Commit 3943162

Browse files
JochemKuijpersRenato Mameli
authored and
Renato Mameli
committed
Fixes incorrect Jackson imports in Java templates used in ApiClient.java when useJakartaEe=true (OpenAPITools#18507)
* Adds useJakartaEe condition to select the appropriate Jackson package to import. This also removes the import on the apache-httpclient template where it doesn't actually get used, requiring users to declare additional dependencies for compilation that aren't actually required by the generated code other than for import. * Ran generate-samples.sh
1 parent 03dfd58 commit 3943162

File tree

6 files changed

+16
-3
lines changed

6 files changed

+16
-3
lines changed

modules/openapi-generator/src/main/resources/Java/ApiClient.mustache

+5
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@ import com.fasterxml.jackson.datatype.joda.JodaModule;
88
{{/joda}}
99
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
1010
import java.time.OffsetDateTime;
11+
{{#useJakartaEe}}
12+
import com.fasterxml.jackson.jakarta.rs.json.JacksonJsonProvider;
13+
{{/useJakartaEe}}
14+
{{^useJakartaEe}}
1115
import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
16+
{{/useJakartaEe}}
1217

1318
import com.sun.jersey.api.client.Client;
1419
import com.sun.jersey.api.client.ClientResponse;

modules/openapi-generator/src/main/resources/Java/libraries/apache-httpclient/ApiClient.mustache

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import com.fasterxml.jackson.datatype.joda.JodaModule;
88
{{/joda}}
99
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
1010
import java.time.OffsetDateTime;
11-
import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
1211
import com.fasterxml.jackson.core.type.TypeReference;
1312
import com.fasterxml.jackson.core.JsonProcessingException;
1413
import com.fasterxml.jackson.databind.JavaType;

modules/openapi-generator/src/main/resources/JavaJaxRS/cxf-ext/api_test.mustache

+6
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,14 @@ import org.apache.cxf.transport.common.gzip.GZIPOutInterceptor;
2323
import org.apache.cxf.interceptor.LoggingOutInterceptor;
2424
{{/useLoggingFeature}}
2525

26+
{{#useJakartaEe}}
27+
import com.fasterxml.jackson.jakarta.rs.json.JacksonJsonProvider;
28+
import com.fasterxml.jackson.jakarta.rs.xml.JacksonXMLProvider;
29+
{{/useJakartaEe}}
30+
{{^useJakartaEe}}
2631
import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
2732
import com.fasterxml.jackson.jaxrs.xml.JacksonXMLProvider;
33+
{{/useJakartaEe}}
2834
import org.apache.cxf.jaxrs.provider.MultipartProvider;
2935

3036
import java.util.Arrays;

modules/openapi-generator/src/test/resources/2_0/templates/Java/ApiClient.mustache

+5
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,12 @@ import java.time.OffsetDateTime;
1919
{{#threetenbp}}
2020
import com.fasterxml.jackson.datatype.threetenbp.ThreeTenModule;
2121
{{/threetenbp}}
22+
{{#useJakartaEe}}
23+
import com.fasterxml.jackson.jakarta.rs.json.JacksonJsonProvider;
24+
{{/useJakartaEe}}
25+
{{^useJakartaEe}}
2226
import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
27+
{{/useJakartaEe}}
2328

2429
import com.sun.jersey.api.client.Client;
2530
import com.sun.jersey.api.client.ClientResponse;

samples/client/echo_api/java/apache-httpclient/src/main/java/org/openapitools/client/ApiClient.java

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import com.fasterxml.jackson.databind.*;
1717
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
1818
import java.time.OffsetDateTime;
19-
import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
2019
import com.fasterxml.jackson.core.type.TypeReference;
2120
import com.fasterxml.jackson.core.JsonProcessingException;
2221
import com.fasterxml.jackson.databind.JavaType;

samples/client/petstore/java/apache-httpclient/src/main/java/org/openapitools/client/ApiClient.java

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import com.fasterxml.jackson.databind.*;
1717
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
1818
import java.time.OffsetDateTime;
19-
import com.fasterxml.jackson.jaxrs.json.JacksonJsonProvider;
2019
import com.fasterxml.jackson.core.type.TypeReference;
2120
import com.fasterxml.jackson.core.JsonProcessingException;
2221
import com.fasterxml.jackson.databind.JavaType;

0 commit comments

Comments
 (0)