Merge pull request #5440 from remotion-dev/use-without-arraybuffer-resize

Author: JonnyBurger

packages/media-parser/src/containers/avc/parse-avc.ts

@@ -316,7 +316,11 @@ const findEnd = (buffer: Uint8Array) => {
 };
 
 const inspect = (buffer: Uint8Array, avcState: AvcState): AvcInfo | null => {
-	const iterator = getArrayBufferIterator(buffer, buffer.byteLength);
+	const iterator = getArrayBufferIterator({
+		initialData: buffer,
+		maxBytes: buffer.byteLength,
+		logLevel: 'error',
+	});
 	iterator.startReadingBits();
 	iterator.getBits(1); // forbidden_zero_bit
 	const nal_ref_idc = iterator.getBits(2); // nal_ref_idc

packages/media-parser/src/containers/flac/parse-flac-frame.ts

@@ -91,7 +91,11 @@ const emitSample = async ({
 	data: Uint8Array;
 	offset: number;
 }) => {
-	const iterator = getArrayBufferIterator(data, data.length);
+	const iterator = getArrayBufferIterator({
+		initialData: data,
+		maxBytes: data.length,
+		logLevel: 'error',
+	});
 	const parsed = parseFrameHeader({iterator, state});
 	if (!parsed) {
 		throw new Error('Invalid CRC');

packages/media-parser/src/containers/iso-base-media/get-moov-atom.ts

@@ -72,10 +72,11 @@ export const getMoovAtom = async ({
 			}
 		: null;
 
-	const iterator: BufferIterator = getArrayBufferIterator(
-		new Uint8Array([]),
-		state.contentLength - endOfMdat,
-	);
+	const iterator: BufferIterator = getArrayBufferIterator({
+		initialData: new Uint8Array([]),
+		maxBytes: state.contentLength - endOfMdat,
+		logLevel: 'error',
+	});
 
 	while (true) {
 		const result = await reader.reader.read();

packages/media-parser/src/containers/iso-base-media/mfra/get-mfra-atom.ts

@@ -30,7 +30,11 @@ export const getMfraAtom = async ({
 		prefetchCache,
 	});
 
-	const iterator = getArrayBufferIterator(new Uint8Array(), parentSize);
+	const iterator = getArrayBufferIterator({
+		initialData: new Uint8Array(),
+		maxBytes: parentSize,
+		logLevel: 'error',
+	});
 	while (true) {
 		const res = await result.reader.reader.read();
 		if (res.value) {

packages/media-parser/src/containers/iso-base-media/mfra/get-mfro-atom.ts

@@ -34,7 +34,11 @@ export const getMfroAtom = async ({
 	}
 
 	result.reader.abort();
-	const iterator = getArrayBufferIterator(value, value.length);
+	const iterator = getArrayBufferIterator({
+		initialData: value,
+		maxBytes: value.length,
+		logLevel: 'error',
+	});
 	const size = iterator.getUint32();
 	if (size !== 16) {
 		iterator.destroy();

packages/media-parser/src/containers/iso-base-media/moov/mvhd.ts

@@ -55,15 +55,23 @@ export const parseMvhd = ({
 	const durationInSeconds = Number(durationInUnits) / timeScale;
 
 	const rateArray = iterator.getSlice(4);
-	const rateView = getArrayBufferIterator(rateArray, rateArray.length);
+	const rateView = getArrayBufferIterator({
+		initialData: rateArray,
+		maxBytes: rateArray.length,
+		logLevel: 'error',
+	});
 	const rate =
 		rateView.getInt8() * 10 +
 		rateView.getInt8() +
 		rateView.getInt8() * 0.1 +
 		rateView.getInt8() * 0.01;
 
 	const volumeArray = iterator.getSlice(2);
-	const volumeView = getArrayBufferIterator(volumeArray, volumeArray.length);
+	const volumeView = getArrayBufferIterator({
+		initialData: volumeArray,
+		maxBytes: volumeArray.length,
+		logLevel: 'error',
+	});
 
 	const volume = volumeView.getInt8() + volumeView.getInt8() * 0.1;
 

packages/media-parser/src/containers/iso-base-media/parse-icc-profile.ts

@@ -38,7 +38,11 @@ type Entry = {
 };
 
 export const parseIccProfile = (data: Uint8Array): IccProfile => {
-	const iterator = getArrayBufferIterator(data, data.length);
+	const iterator = getArrayBufferIterator({
+		initialData: data,
+		maxBytes: data.length,
+		logLevel: 'error',
+	});
 	const size = iterator.getUint32();
 	if (size !== data.length) {
 		throw new Error('Invalid ICC profile size');
@@ -96,7 +100,11 @@ export const parseIccProfile = (data: Uint8Array): IccProfile => {
 			entry.tag === 'bXYZ' ||
 			entry.tag === 'wtpt'
 		) {
-			const it = getArrayBufferIterator(found, found.length);
+			const it = getArrayBufferIterator({
+				initialData: found,
+				maxBytes: found.length,
+				logLevel: 'error',
+			});
 			it.discard(4);
 
 			const x = it.getInt32() / 65536;

packages/media-parser/src/containers/riff/seek/fetch-idx1.ts

@@ -42,10 +42,11 @@ export const fetchIdx1 = async ({
 		throw new Error('Content length is null');
 	}
 
-	const iterator = getArrayBufferIterator(
-		new Uint8Array(),
-		contentLength - position + 1,
-	);
+	const iterator = getArrayBufferIterator({
+		initialData: new Uint8Array(),
+		maxBytes: contentLength - position + 1,
+		logLevel: 'error',
+	});
 	while (true) {
 		const res = await result.reader.reader.read();
 		if (res.value) {

packages/media-parser/src/containers/transport-stream/adts-header.ts

@@ -9,7 +9,11 @@ export const readAdtsHeader = (buffer: Uint8Array) => {
 		return null;
 	}
 
-	const iterator = getArrayBufferIterator(buffer, buffer.byteLength);
+	const iterator = getArrayBufferIterator({
+		initialData: buffer,
+		maxBytes: buffer.byteLength,
+		logLevel: 'error',
+	});
 
 	iterator.startReadingBits();
 	const bits = iterator.getBits(12);

packages/media-parser/src/containers/webm/av1-codec-private.ts

@@ -5,7 +5,11 @@ export const parseAv1PrivateData = (
 	data: Uint8Array,
 	colrAtom: ColorParameterBox | null,
 ) => {
-	const iterator = getArrayBufferIterator(data, data.byteLength);
+	const iterator = getArrayBufferIterator({
+		initialData: data,
+		maxBytes: data.byteLength,
+		logLevel: 'error',
+	});
 	iterator.startReadingBits();
 	if (iterator.getBits(1) !== 1) {
 		iterator.destroy();

packages/media-parser/src/containers/webm/description.ts

@@ -59,10 +59,11 @@ export const getAudioDescription = (
 
 	const vorbisBooks = privateData.slice(offset);
 
-	const bufferIterator = getArrayBufferIterator(
-		vorbisInfo.slice(0),
-		vorbisInfo.length,
-	);
+	const bufferIterator = getArrayBufferIterator({
+		initialData: vorbisInfo.slice(0),
+		maxBytes: vorbisInfo.length,
+		logLevel: 'error',
+	});
 
 	// type
 	bufferIterator.getUint8();

packages/media-parser/src/containers/webm/get-sample-from-block.ts

@@ -125,7 +125,11 @@ export const getSampleFromBlock = async ({
 	onVideoTrack: MediaParserOnVideoTrack | null;
 	avcState: AvcState;
 }): Promise<SampleResult> => {
-	const iterator = getArrayBufferIterator(ebml.value, ebml.value.length);
+	const iterator = getArrayBufferIterator({
+		initialData: ebml.value,
+		maxBytes: ebml.value.length,
+		logLevel: 'error',
+	});
 	const trackNumber = iterator.getVint();
 	if (trackNumber === null) {
 		throw new Error('Not enough data to get track number, should not happen');

packages/media-parser/src/containers/webm/make-track.ts

@@ -109,10 +109,11 @@ const getMatroskaVideoCodecString = ({
 
 	if (codec.value === 'V_MPEGH/ISO/HEVC') {
 		const priv = getPrivateData(track);
-		const iterator = getArrayBufferIterator(
-			priv as Uint8Array,
-			(priv as Uint8Array).length,
-		);
+		const iterator = getArrayBufferIterator({
+			initialData: priv as Uint8Array,
+			maxBytes: (priv as Uint8Array).length,
+			logLevel: 'error',
+		});
 
 		return 'hvc1.' + getHvc1CodecString(iterator);
 	}
@@ -216,10 +217,11 @@ const getMatroskaAudioCodecString = (track: TrackEntry): string => {
 	if (codec.value === 'A_AAC') {
 		const priv = getPrivateData(track);
 
-		const iterator = getArrayBufferIterator(
-			priv as Uint8Array,
-			(priv as Uint8Array).length,
-		);
+		const iterator = getArrayBufferIterator({
+			initialData: priv as Uint8Array,
+			maxBytes: (priv as Uint8Array).length,
+			logLevel: 'error',
+		});
 
 		iterator.startReadingBits();
 		/**

packages/media-parser/src/containers/webm/seek/fetch-web-cues.ts

@@ -37,7 +37,11 @@ export const fetchWebmCues = async ({
 	}
 
 	result.reader.abort();
-	const iterator = getArrayBufferIterator(value, value.length);
+	const iterator = getArrayBufferIterator({
+		initialData: value,
+		maxBytes: value.length,
+		logLevel: 'error',
+	});
 	const segment = await expectSegment({
 		iterator,
 		logLevel,