fix(moduleResolution): fixed an issue with Vite's default server conditions being misapplied to externalConditions

Author: Andarist

.changeset/rare-tables-smile.md

@@ -0,0 +1,5 @@
+---
+"@react-router/dev": patch
+---
+
+Fixed an issue with Vite's default server conditions being misapplied to `externalConditions`. This incorrectly enabled `module` condition for externals and broke builds with certain packages, like Emotion.

contributors.yml

@@ -25,6 +25,7 @@
 - amitdahan
 - AmRo045
 - amsal
+- Andarist
 - andreasottosson-polestar
 - andreiduca
 - antonmontrezor

packages/react-router-dev/vite/cloudflare-dev-proxy.ts

@@ -59,7 +59,6 @@ export const cloudflareDevProxyVitePlugin = <Env, Cf extends CfProperties>(
     name: PLUGIN_NAME,
     config: async (config, configEnv) => {
       await preloadVite();
-      const vite = getVite();
       // This is a compatibility layer for Vite 5. Default conditions were
       // automatically added to any custom conditions in Vite 5, but Vite 6
       // removed this behavior. Instead, the default conditions are overridden
@@ -68,9 +67,11 @@ export const cloudflareDevProxyVitePlugin = <Env, Cf extends CfProperties>(
       // conditions arrays exported from Vite. In Vite 5, these default
       // conditions arrays do not exist.
       // https://vite.dev/guide/migration.html#default-value-for-resolve-conditions
-      const serverConditions: string[] = [
-        ...(vite.defaultServerConditions ?? []),
-      ];
+      //
+      // In addition to that, those are external conditions (do not confuse them with server conditions)
+      // and there is no helpful export with the default external conditions (see https://github.com/vitejs/vite/pull/20279 for more details).
+      // So, for now, we are hardcording the default here.
+      const externalConditions: string[] = ["node"];
 
       let configResult = await loadConfig({
         rootDirectory: config.root ?? process.cwd(),
@@ -86,7 +87,7 @@ export const cloudflareDevProxyVitePlugin = <Env, Cf extends CfProperties>(
       return {
         ssr: {
           resolve: {
-            externalConditions: [...workerdConditions, ...serverConditions],
+            externalConditions: [...workerdConditions, ...externalConditions],
           },
         },
       };

packages/react-router-dev/vite/plugin.ts

@@ -3451,8 +3451,7 @@ export async function getEnvironmentOptionsResolvers(
     `file:///${path.join(packageRoot, "module-sync-enabled/index.mjs")}`
   );
   let vite = getVite();
-  let viteServerConditions: string[] = [
-    ...(vite.defaultServerConditions ?? []),
+  let baseServerLikeConditions: string[] = [
     ...(moduleSyncEnabled ? ["module-sync"] : []),
   ];
 
@@ -3512,8 +3511,8 @@ export async function getEnvironmentOptionsResolvers(
   }): EnvironmentOptions {
     let conditions =
       viteCommand === "build"
-        ? viteServerConditions
-        : ["development", ...viteServerConditions];
+        ? baseServerLikeConditions
+        : ["development", ...baseServerLikeConditions];
 
     return mergeEnvironmentOptions(getBaseOptions({ viteUserConfig }), {
       resolve: {
@@ -3522,8 +3521,8 @@ export async function getEnvironmentOptionsResolvers(
           ctx.reactRouterConfig.future.unstable_viteEnvironmentApi
             ? undefined
             : ssrExternals,
-        conditions,
-        externalConditions: conditions,
+        conditions: [...conditions, ...vite.defaultServerConditions],
+        externalConditions: [...conditions, "node"],
       },
       build: {
         // We move SSR-only assets to client assets. Note that the