Skip to content

Commit 9ec5ba1

Browse files
committed
fix(utilities): fix ELEMENTS_WITH_NO_TEXT_CHILDREN naming
1 parent 1575740 commit 9ec5ba1

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

lib/utilities.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ var PRESERVE_CUSTOM_ATTRIBUTES = React.version.split('.')[0] >= 16;
9999

100100
// Taken from
101101
// https://github.com/facebook/react/blob/cae635054e17a6f107a39d328649137b83f25972/packages/react-dom/src/client/validateDOMNesting.js#L213
102-
var ELEMENTS_WITH_TEXT_CHILDREN = new Set([
102+
var ELEMENTS_WITH_NO_TEXT_CHILDREN = new Set([
103103
'tr',
104104
'tbody',
105105
'thead',
@@ -118,7 +118,7 @@ var ELEMENTS_WITH_TEXT_CHILDREN = new Set([
118118
* @returns - Whether node can contain text nodes.
119119
*/
120120
function canTextBeChildOfNode(node) {
121-
return !ELEMENTS_WITH_TEXT_CHILDREN.has(node.name);
121+
return !ELEMENTS_WITH_NO_TEXT_CHILDREN.has(node.name);
122122
}
123123

124124
function returnFirstArg(arg) {
@@ -127,7 +127,7 @@ function returnFirstArg(arg) {
127127

128128
module.exports = {
129129
PRESERVE_CUSTOM_ATTRIBUTES: PRESERVE_CUSTOM_ATTRIBUTES,
130-
ELEMENTS_WITH_TEXT_CHILDREN: ELEMENTS_WITH_TEXT_CHILDREN,
130+
ELEMENTS_WITH_NO_TEXT_CHILDREN: ELEMENTS_WITH_NO_TEXT_CHILDREN,
131131
invertObject: invertObject,
132132
isCustomComponent: isCustomComponent,
133133
setStyleProp: setStyleProp,

test/utilities.test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const React = require('react');
22
const {
33
PRESERVE_CUSTOM_ATTRIBUTES,
4-
ELEMENTS_WITH_TEXT_CHILDREN,
4+
ELEMENTS_WITH_NO_TEXT_CHILDREN,
55
invertObject,
66
isCustomComponent,
77
setStyleProp,
@@ -141,7 +141,7 @@ describe('setStyleProp', () => {
141141
});
142142

143143
describe('canTextBeChildOfNode', () => {
144-
it.each(Array.from(ELEMENTS_WITH_TEXT_CHILDREN))(
144+
it.each(Array.from(ELEMENTS_WITH_NO_TEXT_CHILDREN))(
145145
'returns false since text node cannot be child of %s',
146146
nodeName => {
147147
const node = {

0 commit comments

Comments
 (0)