You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is pretty minor and trivial, but should be addressed nonetheless. It seems that the entirety of the type definitions use the order of <Type, Payload, Meta> (or equivalent). However, ErrorFSA was not updated to use this new order.
That being said... I don't really understand why the ordering was changed... With this new ordering, all apps that use flux-standard-action now are required to define a typeif they want to define a Payload or Meta. For many codebases, the type will remain as string. In my company's codebase - we have had to add a string to almost every instance of FSA (and derivatives).
It seems really weird that the only type that has a value used so commonly that it gets a default should be forced to be first. It being last makes the most logical sense imo; if you want to define just a Payload or Meta, you are not forced to also add a string that would otherwise be set by default.
The text was updated successfully, but these errors were encountered:
Oh and for what it's worth, I am commenting on this ordering change now as I assumed there were more significant reasons for it changing. Looking at the PR where it was changed (#114) now as a result of the issue originally reported here, it seems that it was just an arbitrary stylistic choice, not considering the ramifications described above.
This is pretty minor and trivial, but should be addressed nonetheless. It seems that the entirety of the type definitions use the order of
<Type, Payload, Meta>
(or equivalent). However,ErrorFSA
was not updated to use this new order.That being said... I don't really understand why the ordering was changed... With this new ordering, all apps that use
flux-standard-action
now are required to define atype
if they want to define aPayload
orMeta
. For many codebases, the type will remain asstring
. In my company's codebase - we have had to add astring
to almost every instance ofFSA
(and derivatives).It seems really weird that the only type that has a value used so commonly that it gets a default should be forced to be first. It being last makes the most logical sense imo; if you want to define just a
Payload
orMeta
, you are not forced to also add astring
that would otherwise be set by default.The text was updated successfully, but these errors were encountered: