feat: always enable argocd app (#1555)

Author: j-zimnowoda

.values/env/settings.yaml

@@ -1 +1 @@
-version: 18
+version: 19

helmfile.d/snippets/defaults.yaml

@@ -813,7 +813,7 @@ environments:
           upgrade:
             version: main
         # TODO: update this when schema version changes: (and think more?)
-        version: 18
+        version: 19
         letsencryptRootCA: |
           -----BEGIN CERTIFICATE-----
           MIIFmDCCA4CgAwIBAgIQU9C87nMpOIFKYpfvOHFHFDANBgkqhkiG9w0BAQsFADBm

helmfile.d/snippets/derived.gotmpl

@@ -61,6 +61,8 @@ environments:
           giteaDomain: {{ printf "gitea.%s" $domainSuffix }}
           keycloakDomain: {{ printf "keycloak.%s" $domainSuffix }}
         apps:
+          argocd:
+            enabled: true
           aws-alb-ingress-controller:
             enabled: {{ and (eq $provider "aws") $v.otomi.hasCloudLB }}
           aws-ebs-csi-driver:

tests/fixtures/env/apps/argocd.yaml

@@ -1,3 +1,2 @@
 apps:
-    argocd:
-        enabled: true
+    argocd: {}

tests/fixtures/env/settings.yaml

@@ -109,18 +109,18 @@ status:
             namespace: drone
             revision: '1'
             status: deployed
-            updated: 2023-05-31 09:54:32.168150254 +0000 UTC
+            updated: '2023-05-31 09:54:32.168150254 +0000 UTC'
         harbor/harbor:
             app_version: 1.6.1
             chart: harbor-3.0.0
             name: harbor
             namespace: harbor
             revision: '1'
             status: deployed
-            updated: 2023-05-31 09:54:32.168150254 +0000 UTC
+            updated: '2023-05-31 09:54:32.168150254 +0000 UTC'
     otomi:
         deployingTag: main
         deployingVersion: 0.21.0
         status: deployed
         version: 0.21.0
-version: 18
+version: 19

tests/fixtures/env/teams.yaml

@@ -5,6 +5,7 @@ teamConfig:
             alertmanager: true
             grafana: true
             prometheus: true
+        sealedsecrets: []
         selfService:
             access:
                 - shell
@@ -35,16 +36,31 @@ teamConfig:
             groupMapping: somesecretvalue
         resourceQuota:
             services.loadbalancers: '1'
+        sealedsecrets:
+            - encryptedData:
+                  foo: bar
+              id: 3bfe13bc-1d81-4af1-b098-338ba7339cf8
+              metadata:
+                  annotations:
+                      - key: test
+                        value: annotation
+                  finalizers:
+                      - sealedsecrets.bitnami.com/finalizer-sealedsecret-v1alpha1
+                  labels:
+                      - key: test
+                        value: label
+              name: demo
+              type: kubernetes.io/opaque
         selfService:
+            access:
+                - shell
+                - downloadCertificateAuthority
             apps: []
             service:
                 - ingress
                 - networkPolicy
             team:
                 - alerts
-            access:
-                - shell
-                - downloadCertificateAuthority
     dev:
         id: dev
         managedMonitoring:

values-changes.yaml

@@ -119,3 +119,6 @@ changes:
     relocations:
       - 'teamConfig.{team}.selfService.team.downloadKubeConfig': 'teamConfig.{team}.selfService.access'
       - 'teamConfig.{team}.selfService.team.downloadDockerConfig': 'teamConfig.{team}.selfService.access'
+  - version: 19
+    deletions:
+      - 'apps.argocd.enabled'