Remove unused suffix from image tag

Allda · Allda · commit 3659eb7dd38d · 2022-03-23T17:36:32.000+01:00
When creating container image in Pyxis, the script was adding
unnecessary suffix "-1". This caused inaccurate pull spec in Red Hat
catalog.

JIRA: ISV-1857
diff --git a/operator-pipeline-images/operatorcert/entrypoints/create_container_image.py b/operator-pipeline-images/operatorcert/entrypoints/create_container_image.py
@@ -138,9 +138,7 @@ def create_container_image(
                 "tags": [
                     {
                         "added_date": date_now,
-                        # suffix -1 is added to indicate,
-                        # that it's non- floating tag
-                        "name": args.bundle_version + "-1",
+                        "name": args.bundle_version,
                     },
                 ],
             }
diff --git a/operator-pipeline-images/tests/entrypoints/test_create_container_image.py b/operator-pipeline-images/tests/entrypoints/test_create_container_image.py
@@ -82,7 +82,7 @@ def test_create_container_image(
                     "tags": [
                         {
                             "added_date": "1970-10-10T10:10:10.000000+00:00",
-                            "name": "some_version-1",
+                            "name": "some_version",
                         }
                     ],
                 }
@@ -137,7 +137,7 @@ def test_create_container_image_latest(
                     "tags": [
                         {
                             "added_date": "1970-10-10T10:10:10.000000+00:00",
-                            "name": "some_version-1",
+                            "name": "some_version",
                         },
                         {
                             "added_date": "1970-10-10T10:10:10.000000+00:00",

Original file line number	Diff line number	Diff line change
`@@ -138,9 +138,7 @@ def create_container_image(`
`138`	`138`	`"tags": [`
`139`	`139`	`{`
`140`	`140`	`"added_date": date_now,`
`141`		`- # suffix -1 is added to indicate,`
`142`		`- # that it's non- floating tag`
`143`		`- "name": args.bundle_version + "-1",`
	`141`	`+ "name": args.bundle_version,`
`144`	`142`	`},`
`145`	`143`	`],`
`146`	`144`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ def test_create_container_image(`
`82`	`82`	`"tags": [`
`83`	`83`	`{`
`84`	`84`	`"added_date": "1970-10-10T10:10:10.000000+00:00",`
`85`		`- "name": "some_version-1",`
	`85`	`+ "name": "some_version",`
`86`	`86`	`}`
`87`	`87`	`],`
`88`	`88`	`}`
`@@ -137,7 +137,7 @@ def test_create_container_image_latest(`
`137`	`137`	`"tags": [`
`138`	`138`	`{`
`139`	`139`	`"added_date": "1970-10-10T10:10:10.000000+00:00",`
`140`		`- "name": "some_version-1",`
	`140`	`+ "name": "some_version",`
`141`	`141`	`},`
`142`	`142`	`{`
`143`	`143`	`"added_date": "1970-10-10T10:10:10.000000+00:00",`