fix: issues with disconnecting and completing #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the DDB refactor messed up which keys we needed to remove a record. Upon investigation we had a "topic" as a range key because we used to allow multiple topics per subscription. I'm pulling that out for the time being. - add more logging and fixup the logging function's input - Better DDB logging - The logger function now always gets the object, the type change is additive so it's not a breaking change (I kind of want to move pino for logging and add a concept of log level) - DDB can now support range keys even though we don't use them BREAKING CHANGE: The subscriptions Table has has its range key removed. This will require a migration.
reconbot
force-pushed
the
reconbot/better-logging
branch
from
8c30464 to
0499922
Compare
reconbot
changed the title
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the DDB refactor messed up which keys we needed to remove a record. Upon investigation we had a "topic" as a range key because we used to allow multiple topics per subscription. I'm pulling that out for the time being.
BREAKING CHANGE: The subscriptions Table has has its range key removed. This will require a migration.